Bug 235028 – [Web Animations] getKeyframes() for a CSS Animation should not use computed style for keyframes (part 2)

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

getKeyframes() should not use the computed value for animated properties

[Antoine Quint]

Created attachment 448734 [details]
Patch

[Antti Koivisto]

Comment on attachment 448734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448734&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:674
> +                if (m_pseudoId == PseudoId::None)
> +                    return styleResolver.styleRulesForElement(target, Style::Resolver::AllCSSRules);
> +                return styleResolver.pseudoStyleRulesForElement(target, m_pseudoId, Style::Resolver::AllCSSRules);

You can just call pseudoStyleRulesForElement with PseudoId::None.

Note that this does style resolution. I suppose it doesn't matter here that this is slow?

[Antoine Quint]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 448734 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448734&action=review
> 
> > Source/WebCore/animation/KeyframeEffect.cpp:674
> > +                if (m_pseudoId == PseudoId::None)
> > +                    return styleResolver.styleRulesForElement(target, Style::Resolver::AllCSSRules);
> > +                return styleResolver.pseudoStyleRulesForElement(target, m_pseudoId, Style::Resolver::AllCSSRules);
> 
> You can just call pseudoStyleRulesForElement with PseudoId::None.

Cool! I'll change that.

> Note that this does style resolution. I suppose it doesn't matter here that
> this is slow?

Not a concern at all.

Would you have some tips to obtain a CSSValue with substituted variables? That's the last piece of this puzzle.

[Antoine Quint]

Committed r287835 (245887@trunk): <https://commits.webkit.org/245887@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/87338875>