getKeyframes() should not use the computed value for animated properties
Created attachment 448734 [details] Patch
Comment on attachment 448734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448734&action=review > Source/WebCore/animation/KeyframeEffect.cpp:674 > + if (m_pseudoId == PseudoId::None) > + return styleResolver.styleRulesForElement(target, Style::Resolver::AllCSSRules); > + return styleResolver.pseudoStyleRulesForElement(target, m_pseudoId, Style::Resolver::AllCSSRules); You can just call pseudoStyleRulesForElement with PseudoId::None. Note that this does style resolution. I suppose it doesn't matter here that this is slow?
(In reply to Antti Koivisto from comment #2) > Comment on attachment 448734 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448734&action=review > > > Source/WebCore/animation/KeyframeEffect.cpp:674 > > + if (m_pseudoId == PseudoId::None) > > + return styleResolver.styleRulesForElement(target, Style::Resolver::AllCSSRules); > > + return styleResolver.pseudoStyleRulesForElement(target, m_pseudoId, Style::Resolver::AllCSSRules); > > You can just call pseudoStyleRulesForElement with PseudoId::None. Cool! I'll change that. > Note that this does style resolution. I suppose it doesn't matter here that > this is slow? Not a concern at all. Would you have some tips to obtain a CSSValue with substituted variables? That's the last piece of this puzzle.
Committed r287835 (245887@trunk): <https://commits.webkit.org/245887@trunk>
<rdar://problem/87338875>