Bug 235022 - Modal container observer should classify elements that are styled like clickable controls
Summary: Modal container observer should classify elements that are styled like clicka...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-09 15:46 PST by Wenson Hsieh
Modified: 2022-01-10 16:45 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.37 KB, patch)
2022-01-10 10:42 PST, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-01-09 15:46:16 PST 
.
Comment 1 Wenson Hsieh 2022-01-10 10:42:26 PST 
Created attachment 448772 [details]
Patch
Comment 2 Tim Horton 2022-01-10 12:58:12 PST 
Comment on attachment 448772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448772&action=review

> Source/WebCore/page/ModalContainerObserver.cpp:300
> +static bool listensForUserActivation(const Element& element)

This seems like a handy thing, I'm surprised it's unique to this code.
Comment 3 Wenson Hsieh 2022-01-10 13:09:53 PST 
(In reply to Tim Horton from comment #2)
> Comment on attachment 448772 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448772&action=review
> 
> > Source/WebCore/page/ModalContainerObserver.cpp:300
> > +static bool listensForUserActivation(const Element& element)
> 
> This seems like a handy thing, I'm surprised it's unique to this code.

True! I suppose it is similar to the list in `Node::willRespondToMouseClickEvents()`, but with the addition of some pointer and touch events (and without the editability check).

I could imagine moving it to somewhere like `Node` in the future, if more things outside of ModalContainerObserver find it useful...
Comment 4 EWS 2022-01-10 15:00:03 PST 
Committed r287860 (245904@main): <https://commits.webkit.org/245904@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448772 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-10 15:01:16 PST 
<rdar://problem/87364047>