ASSIGNED 235018
Start taking advantage of C++20 default comparisons 
https://bugs.webkit.org/show_bug.cgi?id=235018
Summary Start taking advantage of C++20 default comparisons
Darin Adler
Reported 2022-01-09 09:42:38 PST
Lets us delete quite a bit of code
Attachments
Patch (586.79 KB, patch)
2022-01-09 14:12 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (589.21 KB, patch)
2022-01-11 15:59 PST, Darin Adler 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (589.38 KB, patch)
2022-01-11 16:42 PST, Darin Adler 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2022-01-09 14:06:34 PST
My first patch probably contains too much for one bug; should be landed in pieces
Darin Adler
Comment 2 2022-01-09 14:12:13 PST
Created attachment 448719 [details] Patch
Darin Adler
Comment 3 2022-01-11 15:59:14 PST
Created attachment 448885 [details] Patch
Darin Adler
Comment 4 2022-01-11 16:42:09 PST
Created attachment 448891 [details] Patch
Yusuke Suzuki
Comment 5 2022-01-11 16:46:06 PST
Unfortunately, our current GCC baseline is GCC 8.3.0, and I think default value comparisons are not supported in that GCC version... According to the https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement, we can upgrade our GCC to 9 at April. So, we can start many features we strongly wanted! https://en.cppreference.com/w/cpp/compiler_support/20
Darin Adler
Comment 6 2022-01-11 16:54:11 PST
(In reply to Yusuke Suzuki from comment #5) > Unfortunately, our current GCC baseline is GCC 8.3.0, and I think default > value comparisons are not supported in that GCC version... > According to the https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement, we > can upgrade our GCC to 9 at April. So, we can start many features we > strongly wanted! > > https://en.cppreference.com/w/cpp/compiler_support/20 Looks like three way comparison is not in GCC until GCC 10, so I really wasted my time on that!
Yusuke Suzuki
Comment 7 2022-01-11 17:14:54 PST
Probably, right now, the best feature we can use is bitfield initializer :) https://en.cppreference.com/w/cpp/language/bit_field#Cpp20_Default_member_initializers_for_bit_fields
Radar WebKit Bug Importer
Comment 8 2022-01-16 09:43:17 PST
<rdar://problem/87654218>
Yusuke Suzuki
Comment 9 2023-05-06 12:18:52 PDT
@Darin Now, GCC gets 10.2, so this patch is unlocked :)
Darin Adler
Comment 10 2023-05-06 12:42:23 PDT
Yes, I hope we can do everything from this patch, but probably not all at once!
Darin Adler
Comment 11 2024-09-28 12:57:02 PDT
*** Bug 256434 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.