Bug 235014 - Implicit keyframe for a CSS Animation should always use the underlying style
Summary: Implicit keyframe for a CSS Animation should always use the underlying style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks: 235138
  Show dependency treegraph
 
Reported: 2022-01-09 05:44 PST by Antoine Quint
Modified: 2022-01-12 12:34 PST (History)
12 users (show)

See Also:


Attachments
Patch (10.50 KB, patch)
2022-01-09 05:49 PST, Antoine Quint
koivisto: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (11.18 KB, patch)
2022-01-09 12:23 PST, Antoine Quint
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-01-09 05:44:52 PST
Implicit keyframe for a CSS Animation should always use the underlying style
Comment 1 Antoine Quint 2022-01-09 05:49:28 PST
Created attachment 448698 [details]
Patch
Comment 2 Antoine Quint 2022-01-09 05:49:57 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/32301
Comment 3 EWS Watchlist 2022-01-09 05:50:38 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Antti Koivisto 2022-01-09 06:45:51 PST
Comment on attachment 448698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448698&action=review

> Source/WebCore/rendering/style/KeyframeList.cpp:92
>          KeyframeValue keyframeValue(keyframe.key(), RenderStyle::clonePtr(*keyframe.style()));
>          for (auto propertyId : keyframe.properties())
>              keyframeValue.addProperty(propertyId);
> +        keyframeValue.setTimingFunction(keyframe.timingFunction());
> +        keyframeValue.setCompositeOperation(keyframe.compositeOperation());

can we just add a copy operator/function to KeyframeValue?
Comment 5 Antoine Quint 2022-01-09 10:07:48 PST
The test failure is due to bug 235019. I'll re-run EWS once that other bug lands.
Comment 6 Antoine Quint 2022-01-09 10:27:20 PST
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 448698 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448698&action=review
> 
> > Source/WebCore/rendering/style/KeyframeList.cpp:92
> >          KeyframeValue keyframeValue(keyframe.key(), RenderStyle::clonePtr(*keyframe.style()));
> >          for (auto propertyId : keyframe.properties())
> >              keyframeValue.addProperty(propertyId);
> > +        keyframeValue.setTimingFunction(keyframe.timingFunction());
> > +        keyframeValue.setCompositeOperation(keyframe.compositeOperation());
> 
> can we just add a copy operator/function to KeyframeValue?

Actually, the only two call sites for fillImplicitKeyframes() are places where we make the copies as well, so I think we can wrap this all up into a single function.
Comment 7 Antoine Quint 2022-01-09 10:56:50 PST
(In reply to Antoine Quint from comment #6)
> (In reply to Antti Koivisto from comment #4)
> > Comment on attachment 448698 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=448698&action=review
> > 
> > > Source/WebCore/rendering/style/KeyframeList.cpp:92
> > >          KeyframeValue keyframeValue(keyframe.key(), RenderStyle::clonePtr(*keyframe.style()));
> > >          for (auto propertyId : keyframe.properties())
> > >              keyframeValue.addProperty(propertyId);
> > > +        keyframeValue.setTimingFunction(keyframe.timingFunction());
> > > +        keyframeValue.setCompositeOperation(keyframe.compositeOperation());
> > 
> > can we just add a copy operator/function to KeyframeValue?
> 
> Actually, the only two call sites for fillImplicitKeyframes() are places
> where we make the copies as well, so I think we can wrap this all up into a
> single function.

Actually, that's not true. I'll attempt to refactor this in a separate patch.
Comment 8 Antoine Quint 2022-01-09 12:23:56 PST
Created attachment 448717 [details]
Patch for landing
Comment 9 EWS 2022-01-09 13:20:54 PST
Committed r287827 (245879@main): <https://commits.webkit.org/245879@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448717 [details].
Comment 10 Radar WebKit Bug Importer 2022-01-09 13:21:22 PST
<rdar://problem/87314805>