Bug 235011 - [LFC][IFC] imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ar-000.html fails with incorrect run position
Summary: [LFC][IFC] imported/w3c/web-platform-tests/css/css-text/word-break/word-break...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-08 19:01 PST by zalan
Modified: 2022-01-15 05:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (12.16 KB, patch)
2022-01-08 19:27 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.95 KB, patch)
2022-01-09 07:25 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (16.96 KB, patch)
2022-01-10 05:09 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (15.47 KB, patch)
2022-01-14 20:28 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-01-08 19:01:42 PST 
ssia.
Comment 1 zalan 2022-01-08 19:27:28 PST 
Created attachment 448693 [details]
Patch
Comment 2 Antti Koivisto 2022-01-08 23:07:25 PST 
Comment on attachment 448693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448693&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:47
> +    enum class UseTrailingWhitespaceMeasuringQuirk : uint8_t { Yes, No };

It is more like an optimization rather than quirk.

It would be good to add a comment that explains what this does and why it is ok in LTR.
Comment 3 zalan 2022-01-09 07:25:59 PST 
Created attachment 448702 [details]
Patch
Comment 4 zalan 2022-01-10 05:09:45 PST 
Created attachment 448735 [details]
Patch
Comment 5 zalan 2022-01-14 20:28:43 PST 
Created attachment 449240 [details]
Patch
Comment 6 EWS 2022-01-15 05:37:57 PST 
Committed r288055 (246075@main): <https://commits.webkit.org/246075@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449240 [details].
Comment 7 Radar WebKit Bug Importer 2022-01-15 05:38:17 PST 
<rdar://problem/87637264>