Bug 234992 - [LBSE] Begin layer-aware RenderSVGRect implementation
Summary: [LBSE] Begin layer-aware RenderSVGRect implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on: 234878 234954
Blocks: 90738 234632
  Show dependency treegraph
 
Reported: 2022-01-07 15:21 PST by Nikolas Zimmermann
Modified: 2022-01-10 05:12 PST (History)
15 users (show)

See Also:


Attachments
Patch, v1 (19.77 KB, patch)
2022-01-07 15:41 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch, v2 (19.76 KB, patch)
2022-01-10 02:00 PST, Nikolas Zimmermann
rbuis: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2022-01-07 15:21:23 PST
Introduce the "layer-aware" RenderSVGRect implementation (inheriting from RenderSVGModelObject, and thus RenderLayerModelObject).
Besides the different inheritance structure with respect to LegacyRenderSVGRect (inheriting from LegacyRenderSVGModelObject, and thus RenderElement -- not RenderLayerModelObject), the implementation is identical to LegacyRenderSVGRect.
Comment 1 Nikolas Zimmermann 2022-01-07 15:41:41 PST
Created attachment 448638 [details]
Patch, v1
Comment 2 Nikolas Zimmermann 2022-01-07 15:42:57 PST
Comment on attachment 448638 [details]
Patch, v1

This patch depends on 234954, postponing r? / EWS until it's resolved.
Comment 3 Nikolas Zimmermann 2022-01-10 02:00:25 PST
Created attachment 448728 [details]
Patch, v2
Comment 4 Rob Buis 2022-01-10 02:41:49 PST
Comment on attachment 448728 [details]
Patch, v2

View in context: https://bugs.webkit.org/attachment.cgi?id=448728&action=review

> Source/WebCore/rendering/svg/RenderSVGRect.h:33
> +#include "SVGRectElement.h"

Could this be forward reference?

> Source/WebCore/svg/SVGRectElement.cpp:94
> +    if (0 && document().settings().layerBasedSVGEngineEnabled())

Maybe false is nicer.
Comment 5 Nikolas Zimmermann 2022-01-10 05:02:10 PST
(In reply to Rob Buis from comment #4)
> Comment on attachment 448728 [details]
> Patch, v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448728&action=review
> 
> > Source/WebCore/rendering/svg/RenderSVGRect.h:33
> > +#include "SVGRectElement.h"
> 
> Could this be forward reference?
Yes, fixed, good catch.

> 
> > Source/WebCore/svg/SVGRectElement.cpp:94
> > +    if (0 && document().settings().layerBasedSVGEngineEnabled())
> 
> Maybe false is nicer.
Both are ugly, but I agree false is less ugly here. Fortunately this is only needed for a short period of time.

Thanks Rob again!
Comment 6 Nikolas Zimmermann 2022-01-10 05:10:59 PST
Committed r287834 (245886@trunk): <https://commits.webkit.org/245886@trunk>
Comment 7 Radar WebKit Bug Importer 2022-01-10 05:11:21 PST
<rdar://problem/87335756>