Bug 234980 - Various RenderLayer issue with <dialog>
Summary: Various RenderLayer issue with <dialog>
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: dialog-element
  Show dependency tree / graph
 
Reported: 2022-01-07 13:02 PST by Tim Nguyen (:ntim)
Modified: 2022-01-19 12:26 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-01-07 13:02:15 PST 
Why?

- Avoid a myriad of establishesTopLayer() checks over the place
- Avoids needing to think about top layer later on


Tasks:
- Make RenderLayer::addChild/updateLayerPosition and anything else that relies on renderer hierarchy
- Need to look into a bunch of new assertions
- Fix visibility code to not be affected by layer reparenting (DOM/flat tree hierarchy should be followed for visibility, like for display)
Comment 1 Radar WebKit Bug Importer 2022-01-13 11:08:30 PST 
<rdar://problem/87560426>
Comment 2 Simon Fraser (smfr) 2022-01-14 11:44:54 PST 
These are the ancestor tree walks I've found that need thinking about in terms of top layer:

    setAncestorChainHasSelfPaintingLayerDescendant
    setAncestorChainHasVisibleDescendant

    SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem

    enclosingScrollableLayer()

    RenderElement::moveLayers
    RenderElement::findNextLayer

    traverseAncestorLayers
    enclosingFragmentedFlowAncestor
Comment 3 Simon Fraser (smfr) 2022-01-19 12:08:24 PST 
I think all the examples above are taken care of by RenderLayer reparenting (fixed in bug 235194).

So the only remaining issue is an incorrect opacity computation in ContentChangeObserver::isVisuallyHidden() (bug 235240).
Comment 4 Simon Fraser (smfr) 2022-01-19 12:20:56 PST 
Closing since this is covered by other bugs.