RESOLVED FIXED 23498
compilation failure on linux/gtk 
https://bugs.webkit.org/show_bug.cgi?id=23498
Summary compilation failure on linux/gtk
Craig Schlenter
Reported 2009-01-23 01:27:23 PST
RenderThemeGtk.cpp and PluginView.cpp don't compile properly as some methods have moved from RenderObject to RenderBox. I'll attach a patch. Please review carefully as I'm clueless about this code and did the changes blindly to make things compile again.
Attachments
patch to fix compilation problem (2.25 KB, patch)
2009-01-23 01:29 PST, Craig Schlenter 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Craig Schlenter
Comment 1 2009-01-23 01:29:20 PST
Created attachment 26963 [details] patch to fix compilation problem
Holger Freyther
Comment 2 2009-01-23 04:49:16 PST
Thanks. The patch looks correct someone came up with another patch and will land it shortly.
Holger Freyther
Comment 3 2009-01-23 08:18:59 PST
Oh, I took your RenderThemeGtk.cpp changes and slightly changed them on top of the other build fix. I think I properly credited this bug and your work.
Darin Adler
Comment 4 2009-01-23 12:37:00 PST
Comment on attachment 26963 [details] patch to fix compilation problem r=me
Note You need to log in before you can comment on or make changes to this bug.