Bug 23498 - compilation failure on linux/gtk
Summary: compilation failure on linux/gtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-23 01:27 PST by Craig Schlenter
Modified: 2009-01-23 12:37 PST (History)
0 users

See Also:


Attachments
patch to fix compilation problem (2.25 KB, patch)
2009-01-23 01:29 PST, Craig Schlenter
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Schlenter 2009-01-23 01:27:23 PST
RenderThemeGtk.cpp and PluginView.cpp don't compile properly as some methods have moved from RenderObject to RenderBox.

I'll attach a patch. Please review carefully as I'm clueless about this code and did the changes blindly to make things compile again.
Comment 1 Craig Schlenter 2009-01-23 01:29:20 PST
Created attachment 26963 [details]
patch to fix compilation problem
Comment 2 Holger Freyther 2009-01-23 04:49:16 PST
Thanks. The patch looks correct someone came up with another patch and will land it shortly.
Comment 3 Holger Freyther 2009-01-23 08:18:59 PST
Oh, I took your RenderThemeGtk.cpp changes and slightly changed them on top of the other build fix. I think I properly credited this bug and your work.
Comment 4 Darin Adler 2009-01-23 12:37:00 PST
Comment on attachment 26963 [details]
patch to fix compilation problem

r=me