Bug 234974 - A/B comparison tests fail trying to look up fuzzy match tolerance
Summary: A/B comparison tests fail trying to look up fuzzy match tolerance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-07 11:52 PST by Tim Horton
Modified: 2022-01-07 15:21 PST (History)
8 users (show)

See Also:


Attachments
Patch (4.32 KB, patch)
2022-01-07 11:53 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2022-01-07 11:52:34 PST
A/B comparison tests fail trying to look up fuzzy match tolerance
Comment 1 Tim Horton 2022-01-07 11:53:22 PST
Created attachment 448615 [details]
Patch
Comment 2 Aditya Keerthi 2022-01-07 14:38:25 PST
Comment on attachment 448615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448615&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:416
> +            fuzzy_tolerance = None
> +            if allow_fuzzy_tolerance:
> +                fuzzy_tolerance = self._fuzzy_tolerance_for_reference(reference_filename)

Not sure what our Python style guide says, but ternary might be nice: `fuzzy_tolerance = self._fuzzy_tolerance_for_reference(reference_filename) if allow_fuzzy_tolerance else None`.
Comment 3 Tim Horton 2022-01-07 14:45:40 PST
Not sure about our Python style guide either, but personally I'm not a big fan of the out-of-order-shortcutting in the trailing style ternary operator.
Comment 4 EWS 2022-01-07 15:20:41 PST
Committed r287790 (245850@main): <https://commits.webkit.org/245850@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448615 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-07 15:21:24 PST
<rdar://problem/87275180>