Bug 234956 - Cache the Widget associated with an AXObject on its AXIsolatedObject.
Summary: Cache the Widget associated with an AXObject on its AXIsolatedObject.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-07 07:30 PST by Andres Gonzalez
Modified: 2022-01-07 12:03 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2022-01-07 07:48 PST, Andres Gonzalez 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2022-01-07 07:30:02 PST 
Cache the Widget associated with an AXObject on its AXIsolatedObject.
Comment 1 Radar WebKit Bug Importer 2022-01-07 07:30:15 PST 
<rdar://problem/87250274>
Comment 2 Andres Gonzalez 2022-01-07 07:48:27 PST 
Created attachment 448590 [details]
Patch
Comment 3 Darin Adler 2022-01-07 09:31:34 PST 
Comment on attachment 448590 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448590&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:2097
> +        [] (WeakPtr<Widget>& typedValue) -> Widget* { return typedValue.get(); },

I don’t think we need the "-> Widget*" on this line of code
Comment 4 Andres Gonzalez 2022-01-07 11:51:57 PST 
In further discussion we concluded that it is problematic to store the Widget pointer in the cache since the object can be accessed from both thread with undefined behavior. The alternative solution is done in https://bugs.webkit.org/show_bug.cgi?id=234973. Closing this bug since it is not longer applicable.