Bug 234955 - Inserting a new @keyframes rule does not start animations that already used this name
Summary: Inserting a new @keyframes rule does not start animations that already used t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks: 235138
  Show dependency treegraph
 
Reported: 2022-01-07 06:04 PST by Antoine Quint
Modified: 2022-01-12 12:37 PST (History)
4 users (show)

See Also:


Attachments
Patch (10.57 KB, patch)
2022-01-07 06:10 PST, Antoine Quint
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-01-07 06:04:48 PST
Inserting a new @keyframes rule does not start animations that already used this name
Comment 1 Antoine Quint 2022-01-07 06:10:24 PST
Created attachment 448583 [details]
Patch
Comment 2 Antti Koivisto 2022-01-07 06:15:54 PST
Comment on attachment 448583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448583&action=review

> Source/WebCore/style/Styleable.cpp:216
> +    for (size_t i = 0; i < animations.size(); ++i) {

Might be good for the AnimationList to expose the underlying const vector so these could use range-for iteration.
Comment 3 Antoine Quint 2022-01-07 07:43:40 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 448583 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448583&action=review
> 
> > Source/WebCore/style/Styleable.cpp:216
> > +    for (size_t i = 0; i < animations.size(); ++i) {
> 
> Might be good for the AnimationList to expose the underlying const vector so
> these could use range-for iteration.

See bug 234957. I'll use the iterator before landing this patch.
Comment 4 Antoine Quint 2022-01-07 11:23:04 PST
Committed r287769 (245829@trunk): <https://commits.webkit.org/245829@trunk>
Comment 5 Radar WebKit Bug Importer 2022-01-07 11:24:24 PST
<rdar://problem/87263414>