Bug 234955 – Inserting a new @keyframes rule does not start animations that already used this name

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Inserting a new @keyframes rule does not start animations that already used this name

[Antoine Quint]

Created attachment 448583 [details]
Patch

[Antti Koivisto]

Comment on attachment 448583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448583&action=review

> Source/WebCore/style/Styleable.cpp:216
> +    for (size_t i = 0; i < animations.size(); ++i) {

Might be good for the AnimationList to expose the underlying const vector so these could use range-for iteration.

[Antoine Quint]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 448583 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448583&action=review
> 
> > Source/WebCore/style/Styleable.cpp:216
> > +    for (size_t i = 0; i < animations.size(); ++i) {
> 
> Might be good for the AnimationList to expose the underlying const vector so
> these could use range-for iteration.

See bug 234957. I'll use the iterator before landing this patch.

[Antoine Quint]

Committed r287769 (245829@trunk): <https://commits.webkit.org/245829@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/87263414>