Bug 234951 - Adopt linkedOnOrAfter() in more places
Summary: Adopt linkedOnOrAfter() in more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-07 02:42 PST by Tim Horton
Modified: 2022-01-07 14:47 PST (History)
13 users (show)

See Also:


Attachments
Patch (12.78 KB, patch)
2022-01-07 02:43 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2022-01-07 02:42:44 PST
Adopt linkedOnOrAfter() in more places
Comment 1 Tim Horton 2022-01-07 02:43:33 PST
Created attachment 448576 [details]
Patch
Comment 2 Wenson Hsieh 2022-01-07 10:48:28 PST
Comment on attachment 448576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448576&action=review

This seems fine to me, given that we are already going down the `PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is never defined on watchOS).

It would be nice if some JSC folks could take a look as well.

Separately, maybe we should consider actually avoiding this check on watchOS?

> Source/JavaScriptCore/API/tests/testapi.mm:-2744
> -#elif PLATFORM(WATCH)

(OOPS!)
Comment 3 Tim Horton 2022-01-07 10:52:51 PST
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 448576 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448576&action=review
> 
> This seems fine to me, given that we are already going down the
> `PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is
> never defined on watchOS).

Good point! Alas.

> It would be nice if some JSC folks could take a look as well.
> 
> Separately, maybe we should consider actually avoiding this check on watchOS?

At the end of this patch series, the LOA checks will actually work /correctly/ on watchOS for the first time, so I don't think we need to special case anything.

> > Source/JavaScriptCore/API/tests/testapi.mm:-2744
> > -#elif PLATFORM(WATCH)
> 
> (OOPS!)
Comment 4 EWS 2022-01-07 14:46:12 PST
Committed r287784 (245844@main): <https://commits.webkit.org/245844@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448576 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-07 14:47:52 PST
<rdar://problem/87273517>