Bug 234951 – Adopt linkedOnOrAfter() in more places

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Adopt linkedOnOrAfter() in more places

[Tim Horton]

Created attachment 448576 [details]
Patch

[Wenson Hsieh]

Comment on attachment 448576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448576&action=review

This seems fine to me, given that we are already going down the `PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is never defined on watchOS).

It would be nice if some JSC folks could take a look as well.

Separately, maybe we should consider actually avoiding this check on watchOS?

> Source/JavaScriptCore/API/tests/testapi.mm:-2744
> -#elif PLATFORM(WATCH)

(OOPS!)

[Tim Horton]

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 448576 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448576&action=review
> 
> This seems fine to me, given that we are already going down the
> `PLATFORM(IOS_FAMILY)` path on watchOS anyways (since `PLATFORM(WATCH)` is
> never defined on watchOS).

Good point! Alas.

> It would be nice if some JSC folks could take a look as well.
> 
> Separately, maybe we should consider actually avoiding this check on watchOS?

At the end of this patch series, the LOA checks will actually work /correctly/ on watchOS for the first time, so I don't think we need to special case anything.

> > Source/JavaScriptCore/API/tests/testapi.mm:-2744
> > -#elif PLATFORM(WATCH)
> 
> (OOPS!)

[EWS]

Committed r287784 (245844@main): <https://commits.webkit.org/245844@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448576 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87273517>