Bug 234936 - Use c++2a instead of gnu++2a for Cocoa builds
Summary: Use c++2a instead of gnu++2a for Cocoa builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-06 13:43 PST by Alex Christensen
Modified: 2022-01-18 13:48 PST (History)
14 users (show)

See Also:

Attachments
Patch (28.64 KB, patch)
2022-01-06 13:45 PST, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (27.24 KB, patch)
2022-01-06 15:25 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-01-06 13:43:49 PST 
Use c++2a instead of gnu++2a for Cocoa builds
Comment 1 Alex Christensen 2022-01-06 13:45:24 PST 
Created attachment 448535 [details]
Patch
Comment 2 EWS Watchlist 2022-01-06 13:46:13 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alex Christensen 2022-01-06 15:25:54 PST 
Created attachment 448540 [details]
Patch
Comment 4 Sam Weinig 2022-01-07 14:56:48 PST 
What's the reasoning behind this. My recollection is we have historically used the gnu++ standard flag (presumably at some point to use some gnu extensions, though clearly not vert much any more).

What is the intended benefit here?
Comment 5 Radar WebKit Bug Importer 2022-01-13 13:44:29 PST 
<rdar://problem/87568556>
Comment 6 Alex Christensen 2022-01-18 13:04:14 PST 
Comment on attachment 448540 [details]
Patch

The intended benefit here is to have a consistent language standard among all WebKit ports.
Comment 7 EWS 2022-01-18 13:47:55 PST 
Committed r288146 (246146@main): <https://commits.webkit.org/246146@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448540 [details].