Bug 234933 - [AppleWin] Some fast/shadow-dom/fullscreen-in-* tests are crashing after r287698
Summary: [AppleWin] Some fast/shadow-dom/fullscreen-in-* tests are crashing after r287698
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 233963
  Show dependency treegraph
 
Reported: 2022-01-06 13:23 PST by Fujii Hironori
Modified: 2022-01-13 13:24 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2022-01-06 13:23:41 PST
Since r287698 (Bug 233963), AppleWin is crashing.

Regressions: Unexpected crashes (5)
  accessibility/insert-children-assert.html [ Crash ]
  fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html [ Crash ]
  fast/shadow-dom/fullscreen-in-shadow-full-screen-ancestor.html [ Crash ]
  fast/shadow-dom/fullscreen-in-shadow-fullscreenElement.html [ Crash ]
  fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html [ Crash ]
Comment 1 Fujii Hironori 2022-01-06 13:29:10 PST
Since WinCairo skip fast/shadow-dom tests, I mannually skipped those tests and ran tests locally. I don't observe such crash with WinCairo.
I thinik WinCairo bots and I are using newer version of MSVC than AppleWin EWS bots. It's worth to try updating the compiler before debugging.
Comment 2 Fujii Hironori 2022-01-07 17:30:59 PST
r287770 reverted the change. The crashes have gone.
> 23:09:08.281 35661 worker/7 fast/shadow-dom/fullscreen-in-shadow-event-should-propagate.html passed
Comment 3 Alex Christensen 2022-01-08 08:48:24 PST
There is a significant amount of different code between AppleWin and WinCairo in the fullscreen implementation.  Could someone check running AppleWin on those tests with bug 233963 applied to see whether it is just needing newer MSVC or whether there is something going on in that code?
Comment 4 Fujii Hironori 2022-01-08 19:21:08 PST
I'm using Visual Studio 2019 version 16.11.8.
I have to work around some compilation errors to compile out AppleWin. https://gist.github.com/fujii/6dd1d7da709ca7c9015b1d0b82b289d9
I don't observe such crashes for AppleWin on my env.
Comment 6 Robert Jenner 2022-01-12 10:39:41 PST
This was also slowing down EWS on Windows. I have added a test expectation for these tests as [ Crash ] for Windows, to take care of the lag on EWS while this is being investigated. Test expectations were added here:

https://trac.webkit.org/changeset/287932/webkit
Comment 7 Robert Jenner 2022-01-12 10:45:27 PST
I missed marking the accessibility test that goes along with this bug as well. Marked here:

https://trac.webkit.org/changeset/287933/webkit
Comment 8 Radar WebKit Bug Importer 2022-01-13 13:24:16 PST
<rdar://problem/87567514>