Bug 234930 - Separate "linked-on-or-{before, after}-everything" override from the SDK version
Summary: Separate "linked-on-or-{before, after}-everything" override from the SDK version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-06 12:11 PST by Tim Horton
Modified: 2022-01-06 18:19 PST (History)
11 users (show)

See Also:

Attachments
Patch (15.88 KB, patch)
2022-01-06 12:12 PST, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (15.75 KB, patch)
2022-01-06 14:16 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2022-01-06 12:11:15 PST 
Separate "linked-on-or-{before, after}-everything" override from the SDK version
Comment 1 Tim Horton 2022-01-06 12:12:12 PST 
Created attachment 448524 [details]
Patch
Comment 2 Tim Horton 2022-01-06 14:16:07 PST 
Created attachment 448537 [details]
Patch
Comment 3 EWS 2022-01-06 15:41:00 PST 
Committed r287720 (245803@main): <https://commits.webkit.org/245803@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448537 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-06 15:42:23 PST 
<rdar://problem/87222930>
Comment 5 Darin Adler 2022-01-06 16:13:19 PST 
Comment on attachment 448537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448537&action=review

> Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53
> +    static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter;

I don’t think std::optional needs NeverDestroyed; pretty sure you can just use a global here.
Comment 6 Tim Horton 2022-01-06 16:58:09 PST 
(In reply to Darin Adler from comment #5)
> Comment on attachment 448537 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448537&action=review
> 
> > Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53
> > +    static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter;
> 
> I don’t think std::optional needs NeverDestroyed; pretty sure you can just
> use a global here.

Good... point. I was following the one above, but there's a pretty good chance that one is my fault too :)
Comment 7 Tim Horton 2022-01-06 18:19:39 PST 
(In reply to Tim Horton from comment #6)
> (In reply to Darin Adler from comment #5)
> > Comment on attachment 448537 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=448537&action=review
> > 
> > > Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:53
> > > +    static NeverDestroyed<std::optional<LinkedOnOrAfterOverride>> linkedOnOrAfter;
> > 
> > I don’t think std::optional needs NeverDestroyed; pretty sure you can just
> > use a global here.
> 
> Good... point. I was following the one above, but there's a pretty good
> chance that one is my fault too :)

I am drive-by fixing both in https://bugs.webkit.org/show_bug.cgi?id=234942