Bug 234901 – Web Inspector: Layers: add reference page button

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 448436 [details]
Patch

[Devin Rousso]

Created attachment 448437 [details]
[Image] after Patch is applied

[Patrick Angle]

Comment on attachment 448436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448436&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.css:73
> +    bottom: 6px;
> +    inset-inline-end: 6px;

Are these the measurements we want to use for any content view? If so is there any value in using the same rule for both this and the Audits tab so that we are less likely to use different measurements in the future?

> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:180
> +        this.element.appendChild(WI.createReferencePageLink("layers-tab"));

NIT: Can we move this to before the call to `_animate()` with the other `appendChild`? Makes it easier to see what we add to the view IMO.

[Devin Rousso]

Comment on attachment 448436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448436&action=review

>> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.css:73
>> +    inset-inline-end: 6px;
> 
> Are these the measurements we want to use for any content view? If so is there any value in using the same rule for both this and the Audits tab so that we are less likely to use different measurements in the future?

Potentially?  I think it's valid to say we'd wanna keep consistent styling across content views if the reference link is always in the bottom-right corner.  But given that this is only the second usage, I'm inclined to just leave it as-is.  We can unify it later if we desire.

>> Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js:180
>> +        this.element.appendChild(WI.createReferencePageLink("layers-tab"));
> 
> NIT: Can we move this to before the call to `_animate()` with the other `appendChild`? Makes it easier to see what we add to the view IMO.

ya sure :)

[Devin Rousso]

Created attachment 448455 [details]
[fast-cq] Patch

[EWS]

Committed r287670 (245767@main): <https://commits.webkit.org/245767@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448455 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87176920>