Bug 234892 – Make WebResourceLoadStatisticsStore a MessageReceiver

• Status: NEW
• Component: New Bugs

[Alex Christensen]

Make WebResourceLoadStatisticsStore a MessageReceiver

[Alex Christensen]

Created attachment 448413 [details]
Patch

[Alex Christensen]

Created attachment 448414 [details]
Patch

[Alex Christensen]

Created attachment 448415 [details]
Patch

[John Wilander]

Comment on attachment 448415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448415&action=review

r=me bar addressing the test failures.

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:-85
> -void WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned(bool value)

Was this intentionally deleted? Doesn't seem to be part of the gist of this patch. A comment on why it can be removed would be good.

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:539
>  void NetworkProcess::updatePrevalentDomainsToBlockCookiesFor(PAL::SessionID sessionID, const Vector<RegistrableDomain>& domainsToBlock, CompletionHandler<void()>&& completionHandler)

Was this particular one not moved?

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:684
> +void NetworkProcess::setShouldEnableSameSiteStrictEnforcementForTesting(PAL::SessionID sessionID, WebCore::SameSiteStrictEnforcementEnabled enabled, CompletionHandler<void()>&& completionHandler)

Nice catch.

> Source/WebKit/UIProcess/WebPageProxy.cpp:5572
> +    websiteDataStore().networkProcess().send(Messages::WebResourceLoadStatisticsStore::LogFrameNavigation(RegistrableDomain { targetURL }, RegistrableDomain { pageURL }, RegistrableDomain { sourceURL }, isRedirect, frame.isMainFrame(), MonotonicTime::now() - m_didFinishDocumentLoadForMainFrameTimestamp, wasPotentiallyInitiatedByUser), sessionID().toUInt64());

Would be nice to be able to send session ID objects directly.

[Alex Christensen]

(In reply to John Wilander from comment #4)
> Comment on attachment 448415 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448415&action=review
> 
> r=me bar addressing the test failures.
> 
> > Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:-85
> > -void WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned(bool value)
> 
> Was this intentionally deleted? Doesn't seem to be part of the gist of this
> patch. A comment on why it can be removed would be good.
It was dead code.  Will note in change log.

> 
> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:539
> >  void NetworkProcess::updatePrevalentDomainsToBlockCookiesFor(PAL::SessionID sessionID, const Vector<RegistrableDomain>& domainsToBlock, CompletionHandler<void()>&& completionHandler)
> 
> Was this particular one not moved?
I only moved the ones that were straightforwardly doing nothing but finding the WebResourceLoadStatisticsStore and forwarding parameters to it.  This one goes to the NetworkStorageSession, so it'll be moved in a different patch.

[Alex Christensen]

Created attachment 448457 [details]
Patch

[Alex Christensen]

Created attachment 448458 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/87471616>

[Darin Adler]

Comment on attachment 448458 [details]
Patch

TestWebKitAPI.ResourceLoadStatistics.DataSummaryWithCachedProcess test is failing