WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
234884
ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback
https://bugs.webkit.org/show_bug.cgi?id=234884
Summary
ServiceWorkerNavigationPreloader::didComplete should make sure to call its bo...
youenn fablet
Reported
2022-01-05 08:28:11 PST
ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback
Attachments
Patch
(1.94 KB, patch)
2022-01-05 08:33 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.97 KB, patch)
2022-01-06 01:27 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-01-05 08:30:55 PST
<
rdar://problem/87146589
>
youenn fablet
Comment 2
2022-01-05 08:33:05 PST
Created
attachment 448391
[details]
Patch
Alex Christensen
Comment 3
2022-01-05 11:43:58 PST
Comment on
attachment 448391
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=448391&action=review
> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp:207 > + // After that point, |this| might be destroyed.
which point? "After calling responseCallback, |this| may be destroyed."
youenn fablet
Comment 4
2022-01-06 01:27:31 PST
Created
attachment 448470
[details]
Patch for landing
EWS
Comment 5
2022-01-06 02:24:53 PST
Committed
r287676
(
245773@main
): <
https://commits.webkit.org/245773@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 448470
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug