Bug 234884 - ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback
Summary: ServiceWorkerNavigationPreloader::didComplete should make sure to call its bo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-05 08:28 PST by youenn fablet
Modified: 2022-01-06 02:24 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.94 KB, patch)
2022-01-05 08:33 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (1.97 KB, patch)
2022-01-06 01:27 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-01-05 08:28:11 PST 
ServiceWorkerNavigationPreloader::didComplete should make sure to call its bodyCallback
Comment 1 Radar WebKit Bug Importer 2022-01-05 08:30:55 PST 
<rdar://problem/87146589>
Comment 2 youenn fablet 2022-01-05 08:33:05 PST 
Created attachment 448391 [details]
Patch
Comment 3 Alex Christensen 2022-01-05 11:43:58 PST 
Comment on attachment 448391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448391&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp:207
> +    // After that point, |this| might be destroyed.

which point?
"After calling responseCallback, |this| may be destroyed."
Comment 4 youenn fablet 2022-01-06 01:27:31 PST 
Created attachment 448470 [details]
Patch for landing
Comment 5 EWS 2022-01-06 02:24:53 PST 
Committed r287676 (245773@main): <https://commits.webkit.org/245773@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448470 [details].