Bug 234876 - Enable WebRTC for Mac Catalyst
Summary: Enable WebRTC for Mac Catalyst
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 234953
  Show dependency tree / graph
 
Reported: 2022-01-05 03:05 PST by youenn fablet
Modified: 2022-02-09 10:14 PST (History)
15 users (show)

See Also:

Attachments
Patch (30.69 KB, patch)
2022-01-05 03:08 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (30.79 KB, patch)
2022-01-05 03:28 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (30.72 KB, patch)
2022-01-07 02:06 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (31.78 KB, patch)
2022-01-07 03:20 PST, youenn fablet 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-01-05 03:05:02 PST 
Enable WebRTC for Mac Catalyst
Comment 1 youenn fablet 2022-01-05 03:08:18 PST 
Created attachment 448375 [details]
Patch
Comment 2 youenn fablet 2022-01-05 03:28:16 PST 
Created attachment 448376 [details]
Patch
Comment 3 youenn fablet 2022-01-07 02:06:06 PST 
Created attachment 448573 [details]
Patch
Comment 4 youenn fablet 2022-01-07 03:20:21 PST 
Created attachment 448579 [details]
Patch
Comment 5 youenn fablet 2022-01-07 03:21:31 PST 
<<rdar://86040748>>
Comment 6 Eric Carlson 2022-01-07 09:27:24 PST 
Comment on attachment 448579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448579&action=review

> Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:58
> +    , m_currentNativePresentationTimeStamp { PAL::kCMTimeInvalid }
> +    , m_currentOutputPresentationTimeStamp { PAL::kCMTimeInvalid }
> +    , m_remainingPrimeDuration { PAL::kCMTimeInvalid }

Why make this change?

> Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:184
> +RetainPtr<CVPixelBufferRef> createBlackPixelBuffer(size_t width, size_t height)

Maybe move this to RealtimeOutgoingVideoSourceCocoa.mm?
Comment 7 Alex Christensen 2022-01-07 16:58:36 PST 
Don't we need rdar://77080901 first?
Comment 8 youenn fablet 2022-01-10 06:08:50 PST 
(In reply to Alex Christensen from comment #7)
> Don't we need rdar://77080901 first?

Yep, we need that one before landing this patch.

(In reply to Eric Carlson from comment #6)
> Comment on attachment 448579 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448579&action=review
> 
> > Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:58
> > +    , m_currentNativePresentationTimeStamp { PAL::kCMTimeInvalid }
> > +    , m_currentOutputPresentationTimeStamp { PAL::kCMTimeInvalid }
> > +    , m_remainingPrimeDuration { PAL::kCMTimeInvalid }
> 
> Why make this change?

So that we do not add soft link headers in the header but keep them in source files.

> > Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:184
> > +RetainPtr<CVPixelBufferRef> createBlackPixelBuffer(size_t width, size_t height)
> 
> Maybe move this to RealtimeOutgoingVideoSourceCocoa.mm?

We should probably move it to a utility file indeed.