NEW 234876
Enable WebRTC for Mac Catalyst 
https://bugs.webkit.org/show_bug.cgi?id=234876
Summary Enable WebRTC for Mac Catalyst
youenn fablet
Reported 2022-01-05 03:05:02 PST
Enable WebRTC for Mac Catalyst
Attachments
Patch (30.69 KB, patch)
2022-01-05 03:08 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (30.79 KB, patch)
2022-01-05 03:28 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (30.72 KB, patch)
2022-01-07 02:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (31.78 KB, patch)
2022-01-07 03:20 PST, youenn fablet 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-01-05 03:08:18 PST
Created attachment 448375 [details] Patch
youenn fablet
Comment 2 2022-01-05 03:28:16 PST
Created attachment 448376 [details] Patch
youenn fablet
Comment 3 2022-01-07 02:06:06 PST
Created attachment 448573 [details] Patch
youenn fablet
Comment 4 2022-01-07 03:20:21 PST
Created attachment 448579 [details] Patch
youenn fablet
Comment 5 2022-01-07 03:21:31 PST
<<rdar://86040748>>
Eric Carlson
Comment 6 2022-01-07 09:27:24 PST
Comment on attachment 448579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448579&action=review > Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:58 > + , m_currentNativePresentationTimeStamp { PAL::kCMTimeInvalid } > + , m_currentOutputPresentationTimeStamp { PAL::kCMTimeInvalid } > + , m_remainingPrimeDuration { PAL::kCMTimeInvalid } Why make this change? > Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:184 > +RetainPtr<CVPixelBufferRef> createBlackPixelBuffer(size_t width, size_t height) Maybe move this to RealtimeOutgoingVideoSourceCocoa.mm?
Alex Christensen
Comment 7 2022-01-07 16:58:36 PST
Don't we need rdar://77080901 first?
youenn fablet
Comment 8 2022-01-10 06:08:50 PST
(In reply to Alex Christensen from comment #7) > Don't we need rdar://77080901 first? Yep, we need that one before landing this patch. (In reply to Eric Carlson from comment #6) > Comment on attachment 448579 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448579&action=review > > > Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:58 > > + , m_currentNativePresentationTimeStamp { PAL::kCMTimeInvalid } > > + , m_currentOutputPresentationTimeStamp { PAL::kCMTimeInvalid } > > + , m_remainingPrimeDuration { PAL::kCMTimeInvalid } > > Why make this change? So that we do not add soft link headers in the header but keep them in source files. > > Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:184 > > +RetainPtr<CVPixelBufferRef> createBlackPixelBuffer(size_t width, size_t height) > > Maybe move this to RealtimeOutgoingVideoSourceCocoa.mm? We should probably move it to a utility file indeed.
Note You need to log in before you can comment on or make changes to this bug.