Bug 23487 - Eliminate the borderTopExtra lie from RenderBox::y()
: Eliminate the borderTopExtra lie from RenderBox::y()
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tables
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Dave Hyatt
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-22 17:23 PST by Dave Hyatt
Modified: 2009-01-22 19:48 PST (History)
0 users

See Also:


Attachments
Patch that not only passes but also progresses layout tests :) (56.17 KB, patch)
2009-01-22 18:41 PST, Dave Hyatt
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2009-01-22 17:23:58 PST
Rework table cells so that the y() coordinate never lies.
Comment 1 Dave Hyatt 2009-01-22 18:41:04 PST
Created attachment 26950 [details]
Patch that not only passes but also progresses layout tests :)
Comment 2 Oliver Hunt 2009-01-22 19:00:50 PST
Comment on attachment 26950 [details]
Patch that not only passes but also progresses layout tests :)

r=me, afaict this looks like it should help perf, but maybe i'm mistaken.  anyhoo, r=me is conditional on perf being good.

also looking at the bit fields for m_intrinsicPaddingTop, m_intrinsicPaddingBottom, and m_widthChanged -- i think we should look at rearranging these to place n_widthChanged first, to reduce the liklihood that we'll end up with either horrific load alignment and/or an unnecessary word being added to RenderTableCell
Comment 3 Dave Hyatt 2009-01-22 19:48:29 PST
Fixed.