Bug 234869 - Refactor CSS property parsing helpers to be a bit more composable
Summary: Refactor CSS property parsing helpers to be a bit more composable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-04 19:10 PST by Sam Weinig
Modified: 2022-01-09 10:56 PST (History)
12 users (show)

See Also:


Attachments
WIP (106.74 KB, patch)
2022-01-04 19:10 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (141.20 KB, patch)
2022-01-08 18:09 PST, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (144.32 KB, patch)
2022-01-08 19:13 PST, Sam Weinig
darin: review+
Details | Formatted Diff | Diff
Patch (146.47 KB, patch)
2022-01-09 09:22 PST, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (144.43 KB, patch)
2022-01-09 09:34 PST, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (144.45 KB, patch)
2022-01-09 10:03 PST, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (144.45 KB, patch)
2022-01-09 10:16 PST, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2022-01-04 19:10:15 PST
We are approaching a combinatorial problem with all the consumeNumberAndAngleRaw..., etc functions. We can do better.
Comment 1 Sam Weinig 2022-01-04 19:10:52 PST Comment hidden (obsolete)
Comment 2 Sam Weinig 2022-01-08 18:09:22 PST Comment hidden (obsolete)
Comment 3 Sam Weinig 2022-01-08 19:13:55 PST
Created attachment 448692 [details]
Patch
Comment 4 Darin Adler 2022-01-09 08:50:53 PST
Comment on attachment 448692 [details]
Patch

Not a fan of "impl", always trying to avoid using that word.
Comment 5 Sam Weinig 2022-01-09 09:20:11 PST
(In reply to Darin Adler from comment #4)
> Comment on attachment 448692 [details]
> Patch
> 
> Not a fan of "impl", always trying to avoid using that word.

Yeah, me either. Replaced MetaConsumerImpl with MetaConsumerDispatcher.
Comment 6 Sam Weinig 2022-01-09 09:22:53 PST Comment hidden (obsolete)
Comment 7 EWS 2022-01-09 09:24:02 PST Comment hidden (obsolete)
Comment 8 Sam Weinig 2022-01-09 09:34:36 PST Comment hidden (obsolete)
Comment 9 Sam Weinig 2022-01-09 10:03:01 PST Comment hidden (obsolete)
Comment 10 Sam Weinig 2022-01-09 10:16:02 PST Comment hidden (obsolete)
Comment 11 EWS 2022-01-09 10:19:31 PST Comment hidden (obsolete)
Comment 12 EWS 2022-01-09 10:55:38 PST
Committed r287825 (245877@main): <https://commits.webkit.org/245877@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448712 [details].
Comment 13 Radar WebKit Bug Importer 2022-01-09 10:56:19 PST
<rdar://problem/87313403>