RESOLVED FIXED 234869
Refactor CSS property parsing helpers to be a bit more composable 
https://bugs.webkit.org/show_bug.cgi?id=234869
Summary Refactor CSS property parsing helpers to be a bit more composable
Sam Weinig
Reported 2022-01-04 19:10:15 PST
We are approaching a combinatorial problem with all the consumeNumberAndAngleRaw..., etc functions. We can do better.
Attachments
WIP (106.74 KB, patch)
2022-01-04 19:10 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (141.20 KB, patch)
2022-01-08 18:09 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (144.32 KB, patch)
2022-01-08 19:13 PST, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
Patch (146.47 KB, patch)
2022-01-09 09:22 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (144.43 KB, patch)
2022-01-09 09:34 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (144.45 KB, patch)
2022-01-09 10:03 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (144.45 KB, patch)
2022-01-09 10:16 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2022-01-04 19:10:52 PST Comment hidden (obsolete)
Sam Weinig
Comment 2 2022-01-08 18:09:22 PST Comment hidden (obsolete)
Sam Weinig
Comment 3 2022-01-08 19:13:55 PST
Created attachment 448692 [details] Patch
Darin Adler
Comment 4 2022-01-09 08:50:53 PST
Comment on attachment 448692 [details] Patch Not a fan of "impl", always trying to avoid using that word.
Sam Weinig
Comment 5 2022-01-09 09:20:11 PST
(In reply to Darin Adler from comment #4) > Comment on attachment 448692 [details] > Patch > > Not a fan of "impl", always trying to avoid using that word. Yeah, me either. Replaced MetaConsumerImpl with MetaConsumerDispatcher.
Sam Weinig
Comment 6 2022-01-09 09:22:53 PST Comment hidden (obsolete)
EWS
Comment 7 2022-01-09 09:24:02 PST Comment hidden (obsolete)
Sam Weinig
Comment 8 2022-01-09 09:34:36 PST Comment hidden (obsolete)
Sam Weinig
Comment 9 2022-01-09 10:03:01 PST Comment hidden (obsolete)
Sam Weinig
Comment 10 2022-01-09 10:16:02 PST Comment hidden (obsolete)
EWS
Comment 11 2022-01-09 10:19:31 PST Comment hidden (obsolete)
EWS
Comment 12 2022-01-09 10:55:38 PST
Committed r287825 (245877@main): <https://commits.webkit.org/245877@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448712 [details].
Radar WebKit Bug Importer
Comment 13 2022-01-09 10:56:19 PST
<rdar://problem/87313403>
Note You need to log in before you can comment on or make changes to this bug.