Bug 234835 - [GTK][a11y] Use invalid as role for detached objects in ATSPI
Summary: [GTK][a11y] Use invalid as role for detached objects in ATSPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: ATSPI
  Show dependency tree / graph
 
Reported: 2022-01-04 00:41 PST by Carlos Garcia Campos
Modified: 2022-01-04 07:09 PST (History)
10 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2022-01-04 00:42 PST, Carlos Garcia Campos 		jdiggs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-01-04 00:41:05 PST 
We are using unknown by mistake.
Comment 1 Carlos Garcia Campos 2022-01-04 00:42:38 PST 
Created attachment 448269 [details]
Patch
Comment 2 Joanmarie Diggs 2022-01-04 06:59:13 PST 
Comment on attachment 448269 [details]
Patch

r+ but with a question: Is there any way to know what the role of the detached object used to be? (if nothing else as a TODO for the future).

FWIW, INVALID and UNKNOWN have the same degree of usefulness (read "none whatsoever") to Orca. Knowing the role of something in the process of being destroyed improves the likelihood that Orca can recover / clean up stored state, etc.
Comment 3 Carlos Garcia Campos 2022-01-04 07:07:26 PST 
(In reply to Joanmarie Diggs from comment #2)
> Comment on attachment 448269 [details]
> Patch
> 
> r+ but with a question: Is there any way to know what the role of the
> detached object used to be? (if nothing else as a TODO for the future).

I don't think so, we have layout tests to check the role of a detached object is invalid.

> FWIW, INVALID and UNKNOWN have the same degree of usefulness (read "none
> whatsoever") to Orca. Knowing the role of something in the process of being
> destroyed improves the likelihood that Orca can recover / clean up stored
> state, etc.

Invalid is what layout tests expect and what atk uses.
Comment 4 Carlos Garcia Campos 2022-01-04 07:09:50 PST 
Committed r287564 (245699@trunk): <https://commits.webkit.org/245699@trunk>