Bug 234834 - [LFC][IFC] fast/text/combining-mark-paint.html is failing (complex text)
Summary: [LFC][IFC] fast/text/combining-mark-paint.html is failing (complex text)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-03 19:20 PST by zalan
Modified: 2022-01-04 15:07 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2022-01-03 19:34 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.12 KB, patch)
2022-01-04 12:39 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-01-03 19:20:09 PST 
ssia
Comment 1 zalan 2022-01-03 19:34:43 PST 
Created attachment 448264 [details]
Patch
Comment 2 Antti Koivisto 2022-01-04 06:28:18 PST 
Comment on attachment 448264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448264&action=review

> Source/WebCore/ChangeLog:8
> +        Apparently it's perfectly valid to have zero width unicode character (e.g. macron) and

French again :(

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:105
> +                && (!canUseSimpleFontCodePath || glyphData.font->widthForGlyph(glyphData.glyph)))

Weird that this is code path specific rather than based which glyph it is.
Comment 3 zalan 2022-01-04 12:39:41 PST 
Created attachment 448325 [details]
Patch
Comment 4 EWS 2022-01-04 15:06:53 PST 
Committed r287591 (245720@main): <https://commits.webkit.org/245720@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448325 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-04 15:07:21 PST 
<rdar://problem/87116969>