Bug 234814 - [PAS] constant-logical-operand clang warnings
Summary: [PAS] constant-logical-operand clang warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-03 05:22 PST by Philippe Normand
Modified: 2022-01-04 05:07 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2022-01-03 05:24 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-01-03 05:22:16 PST 
/app/webkit/WebKitBuild/Release/bmalloc/Headers/bmalloc/pas_utils.h:583:12: warning: use of logical '||' with constant operand [-Wconstant-logical-operand]
    if ((0 || 0))
           ^  ~
/app/webkit/WebKitBuild/Release/bmalloc/Headers/bmalloc/pas_utils.h:583:12: note: use '|' for a bitwise operation
Comment 1 Philippe Normand 2022-01-03 05:24:41 PST 
Created attachment 448228 [details]
Patch
Comment 2 Martin Robinson 2022-01-04 04:31:20 PST 
Comment on attachment 448228 [details]
Patch

This seems pretty reasonable to me.
Comment 3 EWS 2022-01-04 05:06:40 PST 
Committed r287562 (245697@main): <https://commits.webkit.org/245697@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448228 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-04 05:07:20 PST 
<rdar://problem/87086807>