Bug 234804 - Delete most code for beforeload event
Summary: Delete most code for beforeload event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-02 17:20 PST by Ryosuke Niwa
Modified: 2022-01-29 13:01 PST (History)
23 users (show)

See Also:

Attachments
cleanup (49.71 KB, patch)
2022-01-02 17:35 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for ToT (47.06 KB, patch)
2022-01-02 17:48 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed the test (50.45 KB, patch)
2022-01-02 21:28 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed the test (50.48 KB, patch)
2022-01-02 23:22 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (41.83 KB, patch)
2022-01-29 01:02 PST, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-01-02 17:20:03 PST 
Delete code for beforeload event.
The event has been disabled since https://trac.webkit.org/r261946.
Comment 1 Ryosuke Niwa 2022-01-02 17:35:05 PST 
Created attachment 448193 [details]
cleanup
Comment 2 Ryosuke Niwa 2022-01-02 17:48:23 PST 
Created attachment 448195 [details]
Updated for ToT
Comment 3 Ryosuke Niwa 2022-01-02 21:27:28 PST 
There is an existing bug in RenderImage::paintReplaced. Fixing that.
Comment 4 Ryosuke Niwa 2022-01-02 21:28:39 PST 
Created attachment 448203 [details]
Fixed the test
Comment 5 Ryosuke Niwa 2022-01-02 21:28:53 PST 
Comment on attachment 448203 [details]
Fixed the test

Wait for EWS.
Comment 6 Ryosuke Niwa 2022-01-02 23:22:10 PST 
Created attachment 448211 [details]
Fixed the test
Comment 7 Radar WebKit Bug Importer 2022-01-09 17:21:18 PST 
<rdar://problem/87317502>
Comment 8 Ryosuke Niwa 2022-01-28 22:26:22 PST 
Comment on attachment 448211 [details]
Fixed the test

I guess I need to go with a more conservative approach.
Comment 9 Ryosuke Niwa 2022-01-29 01:02:06 PST 
Created attachment 450322 [details]
Patch
Comment 10 Antti Koivisto 2022-01-29 02:38:21 PST 
nice!
Comment 11 Ryosuke Niwa 2022-01-29 13:01:07 PST 
Committed r288793 (246570@trunk): <https://commits.webkit.org/246570@trunk>