Bug 23480 - Add missing method stubs to BackForwardListChromium
Summary: Add missing method stubs to BackForwardListChromium
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on: 23384
  Show dependency treegraph
Reported: 2009-01-22 10:35 PST by Dimitri Glazkov (Google)
Modified: 2009-01-26 08:46 PST (History)
0 users

See Also:

v1 submitted for review (651 bytes, patch)
2009-01-22 10:40 PST, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
v1 submitted for review (1.24 KB, patch)
2009-01-22 10:40 PST, Dimitri Glazkov (Google)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-01-22 10:35:41 PST
It turns out that two methods are being called by Page::goBack and Page::goForward, respectively -- it's the respective callsites that are never being called.

For more information, see bug 23384.
Comment 1 Dimitri Glazkov (Google) 2009-01-22 10:40:02 PST
Created attachment 26931 [details]
v1 submitted for review

 WebCore/history/BackForwardListChromium.cpp |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
Comment 2 Dimitri Glazkov (Google) 2009-01-22 10:40:51 PST
Created attachment 26932 [details]
v1 submitted for review

 WebCore/ChangeLog                           |   11 +++++++++++
 WebCore/history/BackForwardListChromium.cpp |   12 ++++++++++++
 2 files changed, 23 insertions(+), 0 deletions(-)
Comment 3 Darin Adler 2009-01-23 16:06:14 PST
Comment on attachment 26932 [details]
v1 submitted for review

Darin Fisher and I discussed leaving out unneeded functions intentionally, using the linker to find the error.

Since you're submitting a patch to add these back, I guess there must be some code that's calling these. So I don't understand why ASSERT_NOT_REACHED is OK.

You should check with Darin. But r=me
Comment 4 Darin Fisher (:fishd, Google) 2009-01-24 10:38:07 PST
Hi Darin, see comment #0.  It turns out that two of the "not reached" methods are needed because they are referenced by other code that we compile.  See Page::goBack() and Page::goForward().  So, the linker requires us to define those methods.  However, goBack and goForward are never called by WebCore or our WebKit layer, so we can get away with not implementing them.
Comment 5 Dimitri Glazkov (Google) 2009-01-26 08:46:05 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/history/BackForwardListChromium.cpp
Committed r40249