Bug 234794 - [JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases
Summary: [JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle priva...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-02 03:52 PST by Yusuke Suzuki
Modified: 2022-01-02 23:40 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.52 KB, patch)
2022-01-02 03:53 PST, Yusuke Suzuki 		ashvayka: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-01-02 03:52:50 PST 
[JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases
Comment 1 Yusuke Suzuki 2022-01-02 03:53:31 PST 
Created attachment 448173 [details]
Patch
Comment 2 Alexey Shvayka 2022-01-02 08:09:14 PST 
Comment on attachment 448173 [details]
Patch

This is super neat!

Could you please check if the same change is necessary for ShortCircuitReadModifyDotNode::emitBytecode()? Related nodes (AssignDotNode, ReadModifyDotNode) all perform emitPutProperty / emitGetPropertyValue.
Comment 3 Yusuke Suzuki 2022-01-02 23:08:45 PST 
(In reply to Alexey Shvayka from comment #2)
> Comment on attachment 448173 [details]
> Patch
> 
> This is super neat!
> 
> Could you please check if the same change is necessary for
> ShortCircuitReadModifyDotNode::emitBytecode()? Related nodes (AssignDotNode,
> ReadModifyDotNode) all perform emitPutProperty / emitGetPropertyValue.

Nice, added.
Comment 4 Yusuke Suzuki 2022-01-02 23:39:48 PST 
Committed r287531 (245666@trunk): <https://commits.webkit.org/245666@trunk>
Comment 5 Radar WebKit Bug Importer 2022-01-02 23:40:20 PST 
<rdar://problem/87059955>