RESOLVED FIXED 234794
[JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases 
https://bugs.webkit.org/show_bug.cgi?id=234794
Summary [JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle priva...
Yusuke Suzuki
Reported 2022-01-02 03:52:50 PST
[JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases
Attachments
Patch (8.52 KB, patch)
2022-01-02 03:53 PST, Yusuke Suzuki 		ashvayka: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-01-02 03:53:31 PST
Created attachment 448173 [details] Patch
Alexey Shvayka
Comment 2 2022-01-02 08:09:14 PST
Comment on attachment 448173 [details] Patch This is super neat! Could you please check if the same change is necessary for ShortCircuitReadModifyDotNode::emitBytecode()? Related nodes (AssignDotNode, ReadModifyDotNode) all perform emitPutProperty / emitGetPropertyValue.
Yusuke Suzuki
Comment 3 2022-01-02 23:08:45 PST
(In reply to Alexey Shvayka from comment #2) > Comment on attachment 448173 [details] > Patch > > This is super neat! > > Could you please check if the same change is necessary for > ShortCircuitReadModifyDotNode::emitBytecode()? Related nodes (AssignDotNode, > ReadModifyDotNode) all perform emitPutProperty / emitGetPropertyValue. Nice, added.
Yusuke Suzuki
Comment 4 2022-01-02 23:39:48 PST
Committed r287531 (245666@trunk): <https://commits.webkit.org/245666@trunk>
Radar WebKit Bug Importer
Comment 5 2022-01-02 23:40:20 PST
<rdar://problem/87059955>
Note You need to log in before you can comment on or make changes to this bug.