Bug 234793 - [Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule
Summary: [Web Animations] getKeyframes() should return an empty object when there are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks: 235138
  Show dependency tree / graph
 
Reported: 2022-01-02 03:37 PST by Antoine Quint
Modified: 2022-01-12 12:41 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2022-01-02 03:39 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-01-02 03:37:00 PST 
[Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule
Comment 1 Antoine Quint 2022-01-02 03:39:15 PST 
Created attachment 448172 [details]
Patch
Comment 2 Dean Jackson 2022-01-02 07:00:22 PST 
Comment on attachment 448172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448172&action=review

> Source/WebCore/rendering/style/KeyframeList.cpp:139
> +    for (auto cssPropertyId : m_properties) {
> +        if (CSSPropertyAnimation::isPropertyAnimatable(cssPropertyId))
> +            return true;

Shame there isn't the equivalent of Array.some on Vector.
Comment 3 EWS 2022-01-02 08:13:46 PST 
Committed r287517 (245652@main): <https://commits.webkit.org/245652@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448172 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-02 08:14:27 PST 
<rdar://problem/87049042>