WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 234793
[Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule
https://bugs.webkit.org/show_bug.cgi?id=234793
Summary
[Web Animations] getKeyframes() should return an empty object when there are ...
Antoine Quint
Reported
2022-01-02 03:37:00 PST
[Web Animations] getKeyframes() should return an empty object when there are no animatable properties in @keyframes rule
Attachments
Patch
(5.58 KB, patch)
2022-01-02 03:39 PST
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2022-01-02 03:39:15 PST
Created
attachment 448172
[details]
Patch
Dean Jackson
Comment 2
2022-01-02 07:00:22 PST
Comment on
attachment 448172
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=448172&action=review
> Source/WebCore/rendering/style/KeyframeList.cpp:139 > + for (auto cssPropertyId : m_properties) { > + if (CSSPropertyAnimation::isPropertyAnimatable(cssPropertyId)) > + return true;
Shame there isn't the equivalent of Array.some on Vector.
EWS
Comment 3
2022-01-02 08:13:46 PST
Committed
r287517
(
245652@main
): <
https://commits.webkit.org/245652@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 448172
[details]
.
Radar WebKit Bug Importer
Comment 4
2022-01-02 08:14:27 PST
<
rdar://problem/87049042
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug