Bug 234764 - Re-import css/css-writing-modes WPT
Summary: Re-import css/css-writing-modes WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-31 02:56 PST by Tim Nguyen (:ntim)
Modified: 2022-01-01 06:16 PST (History)
5 users (show)

See Also:


Attachments
Patch (177.43 KB, patch)
2021-12-31 03:01 PST, Tim Nguyen (:ntim)
dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (178.47 KB, patch)
2022-01-01 06:13 PST, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-12-31 02:56:50 PST
lots of tests
Comment 1 Tim Nguyen (:ntim) 2021-12-31 03:01:02 PST
Created attachment 448119 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2021-12-31 03:02:07 PST
Comment on attachment 448119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448119&action=review

> LayoutTests/imported/w3c/resources/resource-files.json:1019
> +        "web-platform-tests/css/css-writing-modes/crashtests/orthogonal-percent-height-multicol-crash.html",
> +        "web-platform-tests/css/css-writing-modes/crashtests/orthogonal-scroll-percent-height-crash.html",
> +        "web-platform-tests/css/css-writing-modes/crashtests/orthogonal-table-in-flex-crash.html",
> +        "web-platform-tests/css/css-writing-modes/crashtests/wm-body-propagation-crash.html",

I should probably file a bug about the import script detecting these crashtests as resource files :/
Comment 3 Dean Jackson 2021-12-31 08:39:39 PST
Comment on attachment 448119 [details]
Patch

rs=me
Comment 4 Tim Nguyen (:ntim) 2022-01-01 06:13:31 PST
Created attachment 448154 [details]
Patch
Comment 5 Tim Nguyen (:ntim) 2022-01-01 06:16:01 PST
Committed r287499 (245634@trunk): <https://commits.webkit.org/245634@trunk>
Comment 6 Radar WebKit Bug Importer 2022-01-01 06:16:20 PST
<rdar://problem/87040102>