Bug 234720 - [selectors] Import two :focus-visible tests from WPT
Summary: [selectors] Import two :focus-visible tests from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-28 00:28 PST by Manuel Rego Casasnovas
Modified: 2021-12-28 04:30 PST (History)
5 users (show)

See Also:

Attachments
Patch (10.76 KB, patch)
2021-12-28 00:29 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (11.12 KB, patch)
2021-12-28 00:31 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (9.32 KB, patch)
2021-12-28 03:52 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2021-12-28 00:28:54 PST 
[selectors] Import two :focus-visible tests from WPT
Comment 1 Manuel Rego Casasnovas 2021-12-28 00:29:49 PST 
Created attachment 448038 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2021-12-28 00:31:46 PST 
Created attachment 448039 [details]
Patch
Comment 3 Sergio Villar Senin 2021-12-28 03:50:09 PST 
Comment on attachment 448039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448039&action=review

> LayoutTests/ChangeLog:8
> +        Skip the new imported tests as they fail due to webkit.org/b/234139.

IMO you either skip them and add valid expectations or do not skip them and use FAIL expectations.
Comment 4 Manuel Rego Casasnovas 2021-12-28 03:52:18 PST 
Created attachment 448042 [details]
Patch
Comment 5 Manuel Rego Casasnovas 2021-12-28 03:58:02 PST 
(In reply to Sergio Villar Senin from comment #3)
> Comment on attachment 448039 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448039&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Skip the new imported tests as they fail due to webkit.org/b/234139.
> 
> IMO you either skip them and add valid expectations or do not skip them and
> use FAIL expectations.

Yes, I removed the -expected.txt files. Thanks for the review.
Comment 6 EWS 2021-12-28 04:29:40 PST 
Committed r287469 (245604@main): <https://commits.webkit.org/245604@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448042 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-28 04:30:17 PST 
<rdar://problem/86955347>