Bug 234711 – Support color interpolation methods for CSS Gradients

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Support gradient interpolation methods for CSS Gradients

[Sam Weinig]

Created attachment 448016 [details]
Patch

[Sam Weinig]

No rendering tests yet, as those are proving tricky. Only parsing and serialization tests so far.

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Sam Weinig]

Created attachment 448050 [details]
Screenshot of gradient variations

[Sam Weinig]

Created attachment 448051 [details]
Gradient Playground

[Sam Weinig]

Attached playground to test out gradients with all the different interpolation methods at once. (It requires the patch and setting enabled to work).

Also added a screenshot of it working in MiniBrowser.

[Simon Fraser (smfr)]

Comment on attachment 448016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448016&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/gradient-interpolation-method-valid-expected.txt:2
> +FAIL e.style['background-image'] = "linear-gradient(in srgb, red, blue)" should set the property value assert_equals: serialization should be canonical expected "linear-gradient(in srgb, red, blue)" but got "linear-gradient(red, blue)"

Why are these all fails?

[Sam Weinig]

(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 448016 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448016&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/css/css-images/parsing/gradient-interpolation-method-valid-expected.txt:2
> > +FAIL e.style['background-image'] = "linear-gradient(in srgb, red, blue)" should set the property value assert_equals: serialization should be canonical expected "linear-gradient(in srgb, red, blue)" but got "linear-gradient(red, blue)"
> 
> Why are these all fails?

Oh, cause I tried to simplify the test at the last moment and didn't double check things. I have the fix for this.

Thanks for the review.

[Sam Weinig]

Created attachment 448054 [details]
Patch

[EWS]

Committed r287474 (245609@main): <https://commits.webkit.org/245609@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448054 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86963408>