Text is not properly clipped and ellipses are drawn on top of text when using text-overflow: ellipses in conjunction with dir: rtl. You can see this in the last example in the test case for the inline-spelling-markers layout test (attached).
Created attachment 26923 [details] an example
Created attachment 27224 [details] First cut at layout test Any suggestions for extra test cases?
Created attachment 27227 [details] Patch version 1 This is a first cut at a patch, it's not complete but I have some questions before I continue: * In the case of RTL text, the first ellipse isn't spaced properly from the last letter of the text, what's the correct way to add the space between the text and ellipse? * What would be the best place to put the accompanying layout test? * With this patch, RTL links draw an underline only under the ellipses and not the actual text (see attached testcase & screenshot), any ideas where this might stem from? * Is the check for m_dirOverride ok? It's not clear to me why the placement of the EllipsesBox is different using a forced bidi override?
Created attachment 27228 [details] Screenshot of problems with patch 1
Created attachment 27229 [details] HTML used to generate screenshot
Created attachment 27237 [details] Patch version 2 This fixes the issues with the previous patch.
Comment on attachment 27237 [details] Patch version 2 Looks fine to me. r=me
Landed as http://trac.webkit.org/changeset/40620