Bug 23471 - RTL: text-overflow: ellipses draws ellipses on top of text
Summary: RTL: text-overflow: ellipses draws ellipses on top of text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-21 23:41 PST by Jeremy Moskovich
Modified: 2009-02-04 12:34 PST (History)
2 users (show)

See Also:


Attachments
an example (38.13 KB, image/png)
2009-01-21 23:42 PST, Jeremy Moskovich
no flags Details
First cut at layout test (1.25 KB, text/html)
2009-01-31 15:45 PST, Jeremy Moskovich
no flags Details
Patch version 1 (4.46 KB, patch)
2009-01-31 21:38 PST, Jeremy Moskovich
no flags Details | Formatted Diff | Diff
Screenshot of problems with patch 1 (15.82 KB, image/png)
2009-01-31 21:38 PST, Jeremy Moskovich
no flags Details
HTML used to generate screenshot (745 bytes, text/html)
2009-01-31 21:39 PST, Jeremy Moskovich
no flags Details
Patch version 2 (12.59 KB, patch)
2009-02-01 17:09 PST, Jeremy Moskovich
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Moskovich 2009-01-21 23:41:49 PST
Text is not properly clipped and ellipses are drawn on top of text when using text-overflow: ellipses in conjunction with dir: rtl.

You can see this in the last example in the test case for the inline-spelling-markers layout test (attached).
Comment 1 Jeremy Moskovich 2009-01-21 23:42:31 PST
Created attachment 26923 [details]
an example
Comment 2 Jeremy Moskovich 2009-01-31 15:45:40 PST
Created attachment 27224 [details]
First cut at layout test

Any suggestions for extra test cases?
Comment 3 Jeremy Moskovich 2009-01-31 21:38:04 PST
Created attachment 27227 [details]
Patch version 1

This is a first cut at a patch, it's not complete but I have some questions before I continue:
* In the case of RTL text, the first ellipse isn't spaced properly from the last letter of the text, what's the correct way to add the space between the text and ellipse?
* What would be the best place to put the accompanying layout test?
* With this patch, RTL links draw an underline only under the ellipses and not the actual text (see attached testcase & screenshot), any ideas where this might stem from?
* Is the check for m_dirOverride ok?  It's not clear to me why the placement of the EllipsesBox is different using a forced bidi override?
Comment 4 Jeremy Moskovich 2009-01-31 21:38:39 PST
Created attachment 27228 [details]
Screenshot of problems with patch 1
Comment 5 Jeremy Moskovich 2009-01-31 21:39:47 PST
Created attachment 27229 [details]
HTML used to generate screenshot
Comment 6 Jeremy Moskovich 2009-02-01 17:09:08 PST
Created attachment 27237 [details]
Patch version 2

This fixes the issues with the previous patch.
Comment 7 Dave Hyatt 2009-02-04 10:12:31 PST
Comment on attachment 27237 [details]
Patch version 2

Looks fine to me.  r=me
Comment 8 Dimitri Glazkov (Google) 2009-02-04 12:34:36 PST
Landed as http://trac.webkit.org/changeset/40620