WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
234691
Use StyleColor object instead of Color in WebCore
https://bugs.webkit.org/show_bug.cgi?id=234691
Summary
Use StyleColor object instead of Color in WebCore
Sam Weinig
Reported
2021-12-26 10:38:08 PST
The CSS 5 color mutation functions (color-mix(), color-contrast(), relative color syntax) don't work with currentcolor or system-colors as one of their origin colors. This is due to the parser not being the right time to resolve those values, so some intermediate type is going to be needed to late resolve these things (perhaps time for a CSSColor object that can be resolved into a Color when appropriate).
Attachments
Darin’s cut at part of the work for reference
(197.95 KB, patch)
2022-09-07 16:23 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-01-02 10:39:18 PST
<
rdar://problem/87050763
>
Matthieu Dubet
Comment 2
2022-09-06 13:14:31 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/4068
Darin Adler
Comment 3
2022-09-07 16:22:24 PDT
I’m having trouble getting my work in progress pushed to GitHub, so I am going to attach a patch here. Matthieu mentioned he wanted to see my cut at this.
Darin Adler
Comment 4
2022-09-07 16:23:42 PDT
Created
attachment 462189
[details]
Darin’s cut at part of the work for reference
EWS
Comment 5
2022-10-03 12:14:11 PDT
Committed
255095@main
(b6c018250b04): <
https://commits.webkit.org/255095@main
> Reviewed commits have been landed. Closing PR #4068 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug