Bug 234691 - Use StyleColor object instead of Color in WebCore
Summary: Use StyleColor object instead of Color in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matthieu Dubet
URL:
Keywords: InRadar
Depends on:
Blocks: 245970
  Show dependency tree / graph
 
Reported: 2021-12-26 10:38 PST by Sam Weinig
Modified: 2022-10-03 12:14 PDT (History)
4 users (show)

See Also:

Attachments
Darin’s cut at part of the work for reference (197.95 KB, patch)
2022-09-07 16:23 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-12-26 10:38:08 PST 
The CSS 5 color mutation functions (color-mix(), color-contrast(), relative color syntax) don't work with currentcolor or system-colors as one of their origin colors.

This is due to the parser not being the right time to resolve those values, so some intermediate type is going to be needed to late resolve these things (perhaps time for a CSSColor object that can be resolved into a Color when appropriate).
Comment 1 Radar WebKit Bug Importer 2022-01-02 10:39:18 PST 
<rdar://problem/87050763>
Comment 2 Matthieu Dubet 2022-09-06 13:14:31 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4068
Comment 3 Darin Adler 2022-09-07 16:22:24 PDT 
I’m having trouble getting my work in progress pushed to GitHub, so I am going to attach a patch here. Matthieu mentioned he wanted to see my cut at this.
Comment 4 Darin Adler 2022-09-07 16:23:42 PDT 
Created attachment 462189 [details]
Darin’s cut at part of the work for reference
Comment 5 EWS 2022-10-03 12:14:11 PDT 
Committed 255095@main (b6c018250b04): <https://commits.webkit.org/255095@main>

Reviewed commits have been landed. Closing PR #4068 and removing active labels.