Bug 234684 – Update wpt css/css-color tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Update wpt css/css-color tests

[Sam Weinig]

Created attachment 447964 [details]
Patch

[Sam Weinig]

Created attachment 447978 [details]
Patch

[Sam Weinig]

After this import, we can remove a few fast/css/ tests that will now be duplicates (or pretty much, I had to re-write as wpt, but the test cases are the same).

[Sam Weinig]

Created attachment 447981 [details]
Patch

[Sam Weinig]

Unsure what our current policy on what to do with the -ref.html files is.

Seems like it would be nice if we just supported that and didn't need our own -expected.html files.

[Carlos Alberto Lopez Perez]

(In reply to Sam Weinig from comment #5)
> Unsure what our current policy on what to do with the -ref.html files is.
> 
> Seems like it would be nice if we just supported that and didn't need our
> own -expected.html files.

AFAIK The script to import the WPT tests will (in theory) automatically rename the -ref.html files to -expected.html ones

There is some WIP patches at bug 204469 to support finding ref tests via rel=match attributes instead of relying on the filesystem

[Carlos Alberto Lopez Perez]

My previous comment is incorrect, seems -ref.html suffix is supported like -expected.html
Not sure if this has changed recently

[Sam Weinig]

Created attachment 448004 [details]
Patch

[Darin Adler]

Comment on attachment 448004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448004&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-computed.html:454
> +    test_computed_value(`color`, `lch(from peru calc(l * 0.8) c h)`, `lch(49.80138% 54.003296 63.680317)`);

Looks like this test is failing on GTK, somehow the floating point values are not serializing correctly.

Need to expect that failure on that platform?

[Darin Adler]

Comment on attachment 448004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448004&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-valid.html:453
> +    test_valid_value(`color`, `lch(from peru calc(l * 0.8) c h)`, `lch(49.80138% 54.003296 63.680317)`);

Same thing here.

[Sam Weinig]

Created attachment 448048 [details]
Patch

[EWS]

Committed r287473 (245608@main): <https://commits.webkit.org/245608@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448048 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86960861>