Bug 234684 - Update wpt css/css-color tests
Summary: Update wpt css/css-color tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-25 17:55 PST by Sam Weinig
Modified: 2021-12-28 11:50 PST (History)
6 users (show)

See Also:


Attachments
Patch (834.32 KB, patch)
2021-12-25 19:02 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (878.37 KB, patch)
2021-12-26 10:45 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (830.87 KB, patch)
2021-12-26 11:13 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (563.85 KB, patch)
2021-12-27 12:26 PST, Sam Weinig
darin: review+
Details | Formatted Diff | Diff
Patch (564.91 KB, patch)
2021-12-28 09:11 PST, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-12-25 17:55:24 PST
Update wpt css/css-color tests
Comment 1 Sam Weinig 2021-12-25 19:02:08 PST
Created attachment 447964 [details]
Patch
Comment 2 Sam Weinig 2021-12-26 10:45:59 PST
Created attachment 447978 [details]
Patch
Comment 3 Sam Weinig 2021-12-26 10:55:12 PST
After this import, we can remove a few fast/css/ tests that will now be duplicates (or pretty much, I had to re-write as wpt, but the test cases are the same).
Comment 4 Sam Weinig 2021-12-26 11:13:27 PST
Created attachment 447981 [details]
Patch
Comment 5 Sam Weinig 2021-12-26 11:16:45 PST
Unsure what our current policy on what to do with the -ref.html files is.

Seems like it would be nice if we just supported that and didn't need our own -expected.html files.
Comment 6 Carlos Alberto Lopez Perez 2021-12-27 09:27:20 PST
(In reply to Sam Weinig from comment #5)
> Unsure what our current policy on what to do with the -ref.html files is.
> 
> Seems like it would be nice if we just supported that and didn't need our
> own -expected.html files.

AFAIK The script to import the WPT tests will (in theory) automatically rename the -ref.html files to -expected.html ones

There is some WIP patches at bug 204469 to support finding ref tests via rel=match attributes instead of relying on the filesystem
Comment 7 Carlos Alberto Lopez Perez 2021-12-27 10:23:45 PST
My previous comment is incorrect, seems -ref.html suffix is supported like -expected.html
Not sure if this has changed recently
Comment 8 Sam Weinig 2021-12-27 12:26:58 PST
Created attachment 448004 [details]
Patch
Comment 9 Darin Adler 2021-12-27 16:08:17 PST
Comment on attachment 448004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448004&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-computed.html:454
> +    test_computed_value(`color`, `lch(from peru calc(l * 0.8) c h)`, `lch(49.80138% 54.003296 63.680317)`);

Looks like this test is failing on GTK, somehow the floating point values are not serializing correctly.

Need to expect that failure on that platform?
Comment 10 Darin Adler 2021-12-27 16:08:48 PST
Comment on attachment 448004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448004&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-valid.html:453
> +    test_valid_value(`color`, `lch(from peru calc(l * 0.8) c h)`, `lch(49.80138% 54.003296 63.680317)`);

Same thing here.
Comment 11 Sam Weinig 2021-12-28 09:11:02 PST
Created attachment 448048 [details]
Patch
Comment 12 EWS 2021-12-28 11:49:37 PST
Committed r287473 (245608@main): <https://commits.webkit.org/245608@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448048 [details].
Comment 13 Radar WebKit Bug Importer 2021-12-28 11:50:16 PST
<rdar://problem/86960861>