Bug 234676 - [LFC][IFC] Turn InlineContentBreaker::ContinuousContent's leading/trailing member variables to std::optional<InlineLayoutUnit>
Summary: [LFC][IFC] Turn InlineContentBreaker::ContinuousContent's leading/trailing me...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-24 15:38 PST by zalan
Modified: 2021-12-25 22:18 PST (History)
5 users (show)

See Also:

Attachments
Patch (13.88 KB, patch)
2021-12-24 15:51 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.87 KB, patch)
2021-12-24 15:55 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.36 KB, patch)
2021-12-25 13:03 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.36 KB, patch)
2021-12-25 20:16 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-24 15:38:07 PST 
instead of using the magic value of 0.
Comment 1 zalan 2021-12-24 15:51:16 PST 
Created attachment 447949 [details]
Patch
Comment 2 zalan 2021-12-24 15:55:27 PST 
Created attachment 447950 [details]
Patch
Comment 3 Antti Koivisto 2021-12-25 01:32:55 PST 
Comment on attachment 447950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447950&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:516
> -    auto avilableWidth = std::max(0.0f, lineStatus.availableWidth - nonOverflowingContentWidth);
> +    auto avilableWidth = std::max(0.f, lineStatus.availableWidth - nonOverflowingContentWidth);

"avilable"

> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:539
> -        auto avilableWidth = std::max(0.0f, lineStatus.availableWidth - previousContentWidth);
> +        auto avilableWidth = std::max(0.f, lineStatus.availableWidth - previousContentWidth);

here too
Comment 4 zalan 2021-12-25 13:03:44 PST 
Created attachment 447962 [details]
Patch
Comment 5 zalan 2021-12-25 20:16:45 PST 
Created attachment 447967 [details]
Patch
Comment 6 EWS 2021-12-25 22:17:33 PST 
Committed r287442 (245577@main): <https://commits.webkit.org/245577@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447967 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-25 22:18:16 PST 
<rdar://problem/86910704>