Bug 234672 – Entirely remove support for -apple-trailing-word

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Tim Nguyen (:ntim)]

It became no-op in bug 196525, but CSS property parsing/codegen was kept for compatibility on some frameworks using it for Safari detection.

The issues that were opened for the 2 main usages found have since been closed and fixed.

Here are some usages in the wild: https://sourcegraph.com/search?q=context:global+apple-trailing-word&patternType=literal

[Radar WebKit Bug Importer]

<rdar://problem/87036364>

[Tim Nguyen (:ntim)]

Created attachment 450431 [details]
Patch

[Myles C. Maxfield]

I'm of 2 minds about this.

On one hand I want to kill -apple-trailing-word with fire.

On the other hand, it looks like it's still used by at least a few fairly high-visibility repos. cssinjs and reacttips-dev seem worth at least filing issues on.

[Simon Fraser (smfr)]

Comment on attachment 450431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450431&action=review

> Source/WebCore/css/CSSProperties.json:-7650
> -        "-apple-trailing-word": {

Maybe leave it in but mark as "Removed".

[Tim Nguyen (:ntim)]

Created attachment 450505 [details]
Patch

[EWS]

Committed r288869 (246621@main): <https://commits.webkit.org/246621@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450505 [details].

[Jonathan Bedard]

Looks like this is causing webkitpy failures:
https://results.webkit.org/?suite=webkitpy-tests&test=webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties

Not really sure how that happens....

[Myles C. Maxfield]

See https://bugs.webkit.org/show_bug.cgi?id=196575