Bug 234671 - [LFC][IFC] ContinuousContent should tell InlineContentBreaker if the candidate content is hanging
Summary: [LFC][IFC] ContinuousContent should tell InlineContentBreaker if the candidat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-24 13:57 PST by zalan
Modified: 2021-12-26 07:04 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.76 KB, patch)
2021-12-24 16:15 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.61 KB, patch)
2021-12-26 06:34 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-24 13:57:33 PST 
ssia
Comment 1 zalan 2021-12-24 16:15:55 PST 
Created attachment 447952 [details]
Patch
Comment 2 Antti Koivisto 2021-12-25 01:34:55 PST 
Comment on attachment 447952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447952&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:207
> +        auto hangingContentWidth = [&]() -> std::optional<InlineLayoutUnit> {
> +            return isWhitespace && style.whiteSpace() == WhiteSpace::PreWrap ? std::make_optional(logicalWidth) : std::nullopt;
> +        };

maybe not to most necessary lambda
Comment 3 zalan 2021-12-26 06:34:39 PST 
Created attachment 447972 [details]
Patch
Comment 4 EWS 2021-12-26 07:03:42 PST 
Committed r287443 (245578@main): <https://commits.webkit.org/245578@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447972 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-26 07:04:18 PST 
<rdar://problem/86916610>