Bug 234655 - clang-format: Set SpaceAfterTemplateKeyword false
Summary: clang-format: Set SpaceAfterTemplateKeyword false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-23 16:41 PST by Fujii Hironori
Modified: 2022-01-04 12:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2021-12-23 16:49 PST, Fujii Hironori 		don.olmstead: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-12-23 16:41:26 PST 
clang-format: Set SpaceAfterTemplateKeyword false

Bug 183302 added the folowing setting to .clang-format.

> SpaceAfterTemplateKeyword: true

However, no space seems more commmon style.

$ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -exec grep "template<" "{}" \+ | wc -l
1312
$ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -exec grep "template <" "{}" \+ | wc -l
318
Comment 1 Fujii Hironori 2021-12-23 16:49:05 PST 
Created attachment 447919 [details]
Patch
Comment 2 Fujii Hironori 2021-12-26 13:09:53 PST 
grepping *.cpp and *.h:

$ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -o -name "*.h" -exec grep "template<" "{}" \+ | wc -l
7913
$ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -o -name "*.h" -exec grep "template <" "{}" \+ | wc -l
1385
Comment 3 Radar WebKit Bug Importer 2021-12-30 16:42:17 PST 
<rdar://problem/87019846>
Comment 4 Fujii Hironori 2022-01-04 12:59:47 PST 
Committed r287581 (245710@trunk): <https://commits.webkit.org/245710@trunk>