WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
234655
clang-format: Set SpaceAfterTemplateKeyword false
https://bugs.webkit.org/show_bug.cgi?id=234655
Summary
clang-format: Set SpaceAfterTemplateKeyword false
Fujii Hironori
Reported
2021-12-23 16:41:26 PST
clang-format: Set SpaceAfterTemplateKeyword false
Bug 183302
added the folowing setting to .clang-format.
> SpaceAfterTemplateKeyword: true
However, no space seems more commmon style. $ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -exec grep "template<" "{}" \+ | wc -l 1312 $ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -exec grep "template <" "{}" \+ | wc -l 318
Attachments
Patch
(1.25 KB, patch)
2021-12-23 16:49 PST
,
Fujii Hironori
don.olmstead
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Fujii Hironori
Comment 1
2021-12-23 16:49:05 PST
Created
attachment 447919
[details]
Patch
Fujii Hironori
Comment 2
2021-12-26 13:09:53 PST
grepping *.cpp and *.h: $ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -o -name "*.h" -exec grep "template<" "{}" \+ | wc -l 7913 $ find Source/{WTF,WebCore,WebKitLegacy,WebKit} -name "*.cpp" -o -name "*.h" -exec grep "template <" "{}" \+ | wc -l 1385
Radar WebKit Bug Importer
Comment 3
2021-12-30 16:42:17 PST
<
rdar://problem/87019846
>
Fujii Hironori
Comment 4
2022-01-04 12:59:47 PST
Committed
r287581
(
245710@trunk
): <
https://commits.webkit.org/245710@trunk
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug