Bug 234638 - [GTK][a11y] WTR: handle xml-roles attributes to return the right role for landmark with ATSPI
Summary: [GTK][a11y] WTR: handle xml-roles attributes to return the right role for lan...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks: ATSPI
  Show dependency tree / graph
 
Reported: 2021-12-23 06:12 PST by Carlos Garcia Campos
Modified: 2021-12-26 23:35 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2021-12-23 06:13 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-12-23 06:12:42 PST 
We are not handling xml-roles
Comment 1 Carlos Garcia Campos 2021-12-23 06:13:41 PST 
Created attachment 447877 [details]
Patch
Comment 2 Adrian Perez 2021-12-26 14:58:40 PST 
Comment on attachment 447877 [details]
Patch

Patch LGTM, but please do fix the style checker issue before landing.
Comment 3 Carlos Garcia Campos 2021-12-26 23:35:08 PST 
Committed r287454 (245589@trunk): <https://commits.webkit.org/245589@trunk>