Bug 234636 - [:has() pseudo-class] Support :disabled and :enabled pseudo-class invalidation
Summary: [:has() pseudo-class] Support :disabled and :enabled pseudo-class invalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
: 232233 (view as bug list)
Depends on:
Blocks: 234556
  Show dependency tree / graph
 
Reported: 2021-12-23 04:21 PST by Antti Koivisto
Modified: 2023-09-04 21:31 PDT (History)
11 users (show)

See Also:

Attachments
Patch (10.49 KB, patch)
2021-12-23 04:30 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (11.47 KB, patch)
2021-12-23 04:32 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (14.02 KB, patch)
2021-12-26 07:56 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-12-23 04:21:29 PST 
:has(:disabled)
Comment 1 Antti Koivisto 2021-12-23 04:30:46 PST 
Created attachment 447871 [details]
Patch
Comment 2 Antti Koivisto 2021-12-23 04:31:07 PST 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/32182
Comment 3 Antti Koivisto 2021-12-23 04:32:04 PST 
Created attachment 447872 [details]
Patch
Comment 4 EWS Watchlist 2021-12-23 04:32:13 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 Tim Nguyen (:ntim) 2021-12-23 09:25:29 PST 
Comment on attachment 447872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447872&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:164
> +                Style::PseudoClassChangeInvalidation disabledInvalidation(*this, CSSSelector::PseudoClassDisabled);

Does this need something similar for `:enabled`?

Same here and below
Comment 6 Antti Koivisto 2021-12-26 07:45:23 PST 
> Does this need something similar for `:enabled`?

Yeah, good point. Sad there are no tests that fail yet for that.
Comment 7 Antti Koivisto 2021-12-26 07:56:33 PST 
Created attachment 447973 [details]
Patch
Comment 8 EWS 2021-12-26 10:46:40 PST 
Committed r287445 (245580@main): <https://commits.webkit.org/245580@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447973 [details].
Comment 9 Radar WebKit Bug Importer 2021-12-26 10:47:16 PST 
<rdar://problem/86919760>
Comment 10 Tim Nguyen (:ntim) 2023-09-04 21:31:03 PDT 
*** Bug 232233 has been marked as a duplicate of this bug. ***