Bug 234630 - [RISCV64] Add MacroAssemblerRISCV64 operations for testing, comparison
Summary: [RISCV64] Add MacroAssemblerRISCV64 operations for testing, comparison
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 237775
  Show dependency tree / graph
 
Reported: 2021-12-23 01:36 PST by Zan Dobersek
Modified: 2022-03-11 05:33 PST (History)
10 users (show)

See Also:

Attachments
Patch (9.27 KB, patch)
2021-12-23 01:36 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2021-12-23 01:36:19 PST 
[RISCV64] Add MacroAssemblerRISCV64 operations for testing, comparison
Comment 1 Zan Dobersek 2021-12-23 01:36:53 PST 
Created attachment 447864 [details]
Patch
Comment 2 Zan Dobersek 2021-12-23 01:37:35 PST 
Comment on attachment 447864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447864&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:2703
> +    void compareFinalize(RelationalCondition cond, RegisterID lhs, RegisterID rhs, RegisterID dest)

These helper method names are ATM all over the place. I'll clean up and align them at the end.
Comment 3 EWS 2021-12-28 01:46:41 PST 
Committed r287467 (245602@main): <https://commits.webkit.org/245602@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447864 [details].
Comment 4 Radar WebKit Bug Importer 2021-12-28 01:47:16 PST 
<rdar://problem/86953340>