Bug 234627 - Re-enable WebPushD.HandleInjectedPush API test
Summary: Re-enable WebPushD.HandleInjectedPush API test
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2021-12-22 19:06 PST by Alex Christensen
Modified: 2021-12-22 23:02 PST (History)
2 users (show)

See Also:

Patch (3.91 KB, patch)
2021-12-22 19:10 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-12-22 19:06:28 PST
Re-enable WebPushD.HandleInjectedPush API test
Comment 1 Alex Christensen 2021-12-22 19:10:27 PST
Created attachment 447851 [details]
Comment 2 Brady Eidson 2021-12-22 21:03:56 PST
Comment on attachment 447851 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=447851&action=review

> Source/WebKit/webpushd/PushClientConnection.mm:83
> +        // This isn't great, but currently the only user of webpushd in open source builds is TestWebKitAPI and codeSigningIdentifier returns the null String on x86_64 Macs.

Is this comment accurate? Are AppleSilicon Macs really different?

If so, the difference isn't reflected in this code.
Comment 3 Alex Christensen 2021-12-22 22:35:51 PST
Comment on attachment 447851 [details]

The comment seems to be true, but this code makes all Macs behave the same when not using the internal SDK, independent of CPU architecture.
Comment 4 EWS 2021-12-22 23:01:27 PST
Committed r287384 (245524@main): <https://commits.webkit.org/245524@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447851 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-22 23:02:16 PST