Bug 234619 - Hardening: decodeArrayBuffer is missing WARN_UNUSED_RETURN
Summary: Hardening: decodeArrayBuffer is missing WARN_UNUSED_RETURN
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-22 14:29 PST by Brent Fulgham
Modified: 2021-12-22 17:49 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2021-12-22 14:31 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-12-22 14:29:10 PST 
We recently noticed that the template function decodeArrayBuffer is missing WARN_UNUSED_RETURN. This patch just adds the declaration to help us avoid misusing the method.
Comment 1 Brent Fulgham 2021-12-22 14:30:18 PST 
<rdar://problem/62755159>
Comment 2 Brent Fulgham 2021-12-22 14:31:31 PST 
Created attachment 447834 [details]
Patch
Comment 3 Alex Christensen 2021-12-22 16:42:39 PST 
Comment on attachment 447834 [details]
Patch

I see no reason not to do this.
Comment 4 Brent Fulgham 2021-12-22 17:11:08 PST 
Comment on attachment 447834 [details]
Patch

Thank you for the review!
Comment 5 EWS 2021-12-22 17:49:33 PST 
Committed r287380 (245520@main): <https://commits.webkit.org/245520@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447834 [details].