Bug 234602 - Internally unprefix -webkit-text-emphasis properties
Summary: Internally unprefix -webkit-text-emphasis properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-22 06:18 PST by Tim Nguyen (:ntim)
Modified: 2021-12-24 12:20 PST (History)
14 users (show)

See Also:

Attachments
Patch (18.07 KB, patch)
2021-12-22 07:01 PST, Tim Nguyen (:ntim) 		koivisto: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (32.66 KB, patch)
2021-12-22 08:55 PST, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-12-22 06:18:28 PST 
It's already exposed unprefixed externally, let's reflect this internally as well.
Makes it easier to remove prefixed versions later on if needed, and it's also less confusing when going through the CSSProperties.json file.
Comment 1 Tim Nguyen (:ntim) 2021-12-22 07:01:13 PST 
Created attachment 447803 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2021-12-22 08:55:18 PST 
Created attachment 447806 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2021-12-22 08:58:02 PST 
Committed r287356 (245498@trunk): <https://commits.webkit.org/245498@trunk>
Comment 4 Radar WebKit Bug Importer 2021-12-22 08:58:17 PST 
<rdar://problem/86813136>
Comment 5 Tim Nguyen (:ntim) 2021-12-23 09:56:12 PST 
Test gardening for ios done in: https://commits.webkit.org/r287403
Comment 6 Darin Adler 2021-12-24 09:19:30 PST 
Comment on attachment 447806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447806&action=review

> Source/WebCore/style/StyleBuilderCustom.h:115
> -    DECLARE_PROPERTY_CUSTOM_HANDLERS(WebkitTextEmphasisStyle);
> +    DECLARE_PROPERTY_CUSTOM_HANDLERS(TextEmphasisStyle);

Should we sort this one?
Comment 7 Tim Nguyen (:ntim) 2021-12-24 12:20:52 PST 
(In reply to Darin Adler from comment #6)
> Comment on attachment 447806 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447806&action=review
> 
> > Source/WebCore/style/StyleBuilderCustom.h:115
> > -    DECLARE_PROPERTY_CUSTOM_HANDLERS(WebkitTextEmphasisStyle);
> > +    DECLARE_PROPERTY_CUSTOM_HANDLERS(TextEmphasisStyle);
> 
> Should we sort this one?

Fixed in https://commits.webkit.org/r287430