WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
234600
Simplify test for startOfLastParagraph in InsertListCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=234600
Summary
Simplify test for startOfLastParagraph in InsertListCommand::doApply
Frédéric Wang (:fredw)
Reported
2021-12-22 05:52:45 PST
Currently, we are doing !startOfLastParagraph.deepEquivalent().anchorNode()->isConnected() but it could be replaced with startOfLastParagraph.isOrphan() which is the same as startOfLastParagraph.deepEquivalent().isOrphan() and so the same as startOfLastParagraph.deepEquivalent().anchorNode() && !startOfLastParagraph.deepEquivalent().anchorNode()->isConnected()
Attachments
Patch
(2.54 KB, patch)
2021-12-22 06:01 PST
,
Frédéric Wang (:fredw)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1
2021-12-22 06:01:48 PST
Created
attachment 447798
[details]
Patch
EWS
Comment 2
2021-12-24 09:08:12 PST
Committed
r287428
(
245563@main
): <
https://commits.webkit.org/245563@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 447798
[details]
.
Radar WebKit Bug Importer
Comment 3
2021-12-24 09:09:15 PST
<
rdar://problem/86894407
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug