Bug 234584 - [iOS] Scroll view pinch zoom gesture sometimes fails to recognize in WKWebView
Summary: [iOS] Scroll view pinch zoom gesture sometimes fails to recognize in WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-21 18:19 PST by Wenson Hsieh
Modified: 2021-12-22 11:13 PST (History)
6 users (show)

See Also:

Attachments
For EWS (5.28 KB, patch)
2021-12-21 18:23 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
With test (16.11 KB, patch)
2021-12-22 09:08 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
For landing (16.16 KB, patch)
2021-12-22 10:28 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-12-21 18:19:58 PST 
rdar://84379650
Comment 1 Wenson Hsieh 2021-12-21 18:23:09 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-12-22 09:08:15 PST 
Created attachment 447807 [details]
With test
Comment 3 Simon Fraser (smfr) 2021-12-22 10:22:26 PST 
Comment on attachment 447807 [details]
With test

View in context: https://bugs.webkit.org/attachment.cgi?id=447807&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2024
> +    for (WKDeferringGestureRecognizer *gesture in self._touchStartDeferringGestures) {

I would call "gesture" "recognizer" here.
Comment 4 Wenson Hsieh 2021-12-22 10:24:32 PST 
Comment on attachment 447807 [details]
With test

View in context: https://bugs.webkit.org/attachment.cgi?id=447807&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2024
>> +    for (WKDeferringGestureRecognizer *gesture in self._touchStartDeferringGestures) {
> 
> I would call "gesture" "recognizer" here.

Sounds good — renamed the local variable to `gestureRecognizer`.
Comment 5 Wenson Hsieh 2021-12-22 10:28:59 PST 
Created attachment 447816 [details]
For landing
Comment 6 EWS 2021-12-22 11:13:49 PST 
Committed r287366 (245508@main): <https://commits.webkit.org/245508@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447816 [details].