Bug 234574 – REGRESSION (12/21/2021): [iOS] TestWebKitAPI.WebKit.AddAndRemoveDataDetectors is consistently failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

TestWebKitAPI.WebKit.AddAndRemoveDataDetectors is consistently failing on iOS bots as of r287296

TestWebKitAPI.WebKit.AddAndRemoveDataDetectors
        2021-12-21 05:31:26.975 TestWebKitAPI[11559:16050223] Writing analzed variants.
        
        /Volumes/Data/worker/ios-simulator-15-release/build/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:204
        Expected equality of these values:
          count
            Which is: 5
          [self stringByEvaluatingJavaScript:script].integerValue
            Which is: 4


https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.AddAndRemoveDataDetectors

[Radar WebKit Bug Importer]

<rdar://problem/86782559>

[Wenson Hsieh]

Regression point seems rather unlikely, but I can take a look...

[Wenson Hsieh]

```
TEST(WebKit, AddAndRemoveDataDetectors)
{

…

        EXPECT_WK_STREQ("December 21, 2021", results[1].value);
```


🤦🏻‍♂️

I should be able to fix this by just bumping the year to *much* later date..

[Wenson Hsieh]

Created attachment 447768 [details]
Patch

[Alexey Proskuryakov]

No one we care about will live to suffer from this in 2099? ;)

[Wenson Hsieh]

Comment on attachment 447768 [details]
Patch

(In reply to Alexey Proskuryakov from comment #5)
> No one we care about will live to suffer from this in 2099? ;)

😅

[EWS]

Committed r287340 (245482@main): <https://commits.webkit.org/245482@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447768 [details].