Bug 234574 - REGRESSION (12/21/2021): [iOS] TestWebKitAPI.WebKit.AddAndRemoveDataDetectors is consistently failing
Summary: REGRESSION (12/21/2021): [iOS] TestWebKitAPI.WebKit.AddAndRemoveDataDetectors...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-21 13:35 PST by Ryan Haddad
Modified: 2021-12-21 19:27 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2021-12-21 17:48 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-12-21 13:35:29 PST 
TestWebKitAPI.WebKit.AddAndRemoveDataDetectors is consistently failing on iOS bots as of r287296

TestWebKitAPI.WebKit.AddAndRemoveDataDetectors
        2021-12-21 05:31:26.975 TestWebKitAPI[11559:16050223] Writing analzed variants.
        
        /Volumes/Data/worker/ios-simulator-15-release/build/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:204
        Expected equality of these values:
          count
            Which is: 5
          [self stringByEvaluatingJavaScript:script].integerValue
            Which is: 4


https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WebKit.AddAndRemoveDataDetectors
Comment 1 Radar WebKit Bug Importer 2021-12-21 13:35:42 PST 
<rdar://problem/86782559>
Comment 2 Wenson Hsieh 2021-12-21 13:37:15 PST 
Regression point seems rather unlikely, but I can take a look...
Comment 3 Wenson Hsieh 2021-12-21 17:31:54 PST 
```
TEST(WebKit, AddAndRemoveDataDetectors)
{

…

        EXPECT_WK_STREQ("December 21, 2021", results[1].value);
```


🤦🏻‍♂️

I should be able to fix this by just bumping the year to *much* later date..
Comment 4 Wenson Hsieh 2021-12-21 17:48:49 PST 
Created attachment 447768 [details]
Patch
Comment 5 Alexey Proskuryakov 2021-12-21 18:41:49 PST 
No one we care about will live to suffer from this in 2099? ;)
Comment 6 Wenson Hsieh 2021-12-21 19:11:17 PST 
Comment on attachment 447768 [details]
Patch

(In reply to Alexey Proskuryakov from comment #5)
> No one we care about will live to suffer from this in 2099? ;)

😅
Comment 7 EWS 2021-12-21 19:27:12 PST 
Committed r287340 (245482@main): <https://commits.webkit.org/245482@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447768 [details].