Bug 234569 - Don't create LocalStorage database for read if it does not exist
Summary: Don't create LocalStorage database for read if it does not exist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-21 10:40 PST by Sihui Liu
Modified: 2021-12-23 17:51 PST (History)
4 users (show)

See Also:


Attachments
Patch (9.41 KB, patch)
2021-12-21 10:45 PST, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (10.17 KB, patch)
2021-12-23 16:40 PST, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (10.16 KB, patch)
2021-12-23 16:55 PST, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-12-21 10:40:11 PST
...
Comment 1 Sihui Liu 2021-12-21 10:45:21 PST
Created attachment 447734 [details]
Patch
Comment 2 Alex Christensen 2021-12-23 10:22:39 PST
Comment on attachment 447734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447734&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm:35
> +static NSString *expectedMessage;

Add an ivar to LocalStorageUIDelegate instead of a new static global, which I've been working to remove in TestWebKitAPI.
[[LocalStorageUIDelegate alloc] initWithExpectedMessage:@"testValue"]
Comment 3 Sihui Liu 2021-12-23 16:40:34 PST
Created attachment 447918 [details]
Patch for landing
Comment 4 Sihui Liu 2021-12-23 16:55:39 PST
Created attachment 447921 [details]
Patch for landing
Comment 5 EWS 2021-12-23 17:50:35 PST
Committed r287418 (245553@main): <https://commits.webkit.org/245553@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447921 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-23 17:51:18 PST
<rdar://problem/86870643>