Bug 234565 - PCM tests crashing with 'unlink' errors
Summary: PCM tests crashing with 'unlink' errors
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
Keywords: InRadar
Depends on:
Reported: 2021-12-21 09:09 PST by Kate Cheney
Modified: 2021-12-22 14:25 PST (History)
3 users (show)

See Also:

Patch (31.75 KB, patch)
2021-12-21 09:20 PST, Kate Cheney
no flags Details | Formatted Diff | Diff
Patch (34.71 KB, patch)
2021-12-21 11:26 PST, Kate Cheney
no flags Details | Formatted Diff | Diff
Patch for landing (34.67 KB, patch)
2021-12-22 13:23 PST, Kate Cheney
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-12-21 09:09:58 PST
PCM tests are crashing in various places with file unlink errors, which usually occur when trying to delete a database that is still open.
Comment 1 Radar WebKit Bug Importer 2021-12-21 09:10:18 PST
Comment 2 Kate Cheney 2021-12-21 09:20:28 PST
Created attachment 447723 [details]
Comment 3 Kate Cheney 2021-12-21 11:26:11 PST
Created attachment 447737 [details]
Comment 4 Alex Christensen 2021-12-21 14:44:12 PST
Comment on attachment 447737 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=447737&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:323
> +        EXPECT_FALSE([defaultFileManager fileExistsAtPath:itpRoot]);

This isn't necessary.  If we exited the while loop, we know it is false.
Comment 5 Kate Cheney 2021-12-22 13:23:36 PST
Created attachment 447828 [details]
Patch for landing
Comment 6 EWS 2021-12-22 14:25:06 PST
Committed r287371 (245512@main): <https://commits.webkit.org/245512@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447828 [details].