WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
234565
PCM tests crashing with 'unlink' errors
https://bugs.webkit.org/show_bug.cgi?id=234565
Summary
PCM tests crashing with 'unlink' errors
Kate Cheney
Reported
2021-12-21 09:09:58 PST
PCM tests are crashing in various places with file unlink errors, which usually occur when trying to delete a database that is still open.
Attachments
Patch
(31.75 KB, patch)
2021-12-21 09:20 PST
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Patch
(34.71 KB, patch)
2021-12-21 11:26 PST
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Patch for landing
(34.67 KB, patch)
2021-12-22 13:23 PST
,
Kate Cheney
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-12-21 09:10:18 PST
<
rdar://problem/86771766
>
Kate Cheney
Comment 2
2021-12-21 09:20:28 PST
Created
attachment 447723
[details]
Patch
Kate Cheney
Comment 3
2021-12-21 11:26:11 PST
Created
attachment 447737
[details]
Patch
Alex Christensen
Comment 4
2021-12-21 14:44:12 PST
Comment on
attachment 447737
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=447737&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:323 > + EXPECT_FALSE([defaultFileManager fileExistsAtPath:itpRoot]);
This isn't necessary. If we exited the while loop, we know it is false.
Kate Cheney
Comment 5
2021-12-22 13:23:36 PST
Created
attachment 447828
[details]
Patch for landing
EWS
Comment 6
2021-12-22 14:25:06 PST
Committed
r287371
(
245512@main
): <
https://commits.webkit.org/245512@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 447828
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug