Bug 234555 - [JSC] Remove m_calleeSaveRegisters from CodeBlock::JITData and rename it to BaselineJITData
Summary: [JSC] Remove m_calleeSaveRegisters from CodeBlock::JITData and rename it to B...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-21 03:05 PST by Yusuke Suzuki
Modified: 2022-01-04 16:21 PST (History)
7 users (show)

See Also:

Attachments
Patch (34.62 KB, patch)
2021-12-21 03:06 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (52.40 KB, patch)
2021-12-21 04:13 PST, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (52.46 KB, patch)
2021-12-21 04:25 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (53.18 KB, patch)
2021-12-25 03:43 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-12-21 03:05:41 PST 
[JSC] Remove m_calleeSaveRegisters from CodeBlock::JITData and rename it to BaselineJITData
Comment 1 Yusuke Suzuki 2021-12-21 03:06:07 PST 
Created attachment 447707 [details]
Patch
Comment 2 Yusuke Suzuki 2021-12-21 04:13:46 PST 
Created attachment 447710 [details]
Patch
Comment 3 Yusuke Suzuki 2021-12-21 04:25:32 PST 
Created attachment 447711 [details]
Patch
Comment 4 Yusuke Suzuki 2021-12-25 03:43:31 PST 
Created attachment 447958 [details]
Patch
Comment 5 Yusuke Suzuki 2021-12-25 03:46:54 PST 
Comment on attachment 447958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447958&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:481
> +        if (*ptr >= Options::earlyReturnFromInfiniteLoopsLimit())
>              LLINT_RETURN_TWO(LLInt::fuzzerReturnEarlyFromLoopHintEntrypoint().code().executableAddress(), callFrame->topOfFrame());

We do not need ensureJITData since we no longer load a pointer from JITData (we removed that indirection).
Comment 6 Radar WebKit Bug Importer 2021-12-28 03:06:16 PST 
<rdar://problem/86954269>
Comment 7 Saam Barati 2022-01-04 13:16:33 PST 
Comment on attachment 447958 [details]
Patch

r=me
Comment 8 EWS 2022-01-04 16:21:52 PST 
Committed r287596 (245724@main): <https://commits.webkit.org/245724@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447958 [details].